Multi-broadcasting: fix reported issues#1418
Merged
daschuer merged 3 commits intomixxxdj:masterfrom Dec 17, 2017
Palakis:broadcasting-fix-161217
Merged
Multi-broadcasting: fix reported issues#1418daschuer merged 3 commits intomixxxdj:masterfrom Palakis:broadcasting-fix-161217
daschuer merged 3 commits intomixxxdj:masterfrom
Palakis:broadcasting-fix-161217
Conversation
Member
|
Thank you for caring about this! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues reported on PR #1300 and the forum (thread here) regarding the Live Broadcasting settings UI:
BroadcastProfile.QTableView::selectRowwhen updating but this method only updates the UI without triggering the expected "selection changed" signals.