Fix crash due to concurrent access in MidiController#13980
Closed
daschuer wants to merge 6 commits into
Closed
Conversation
Member
|
Such threading issues require a longer testing period, than we have until 2.5.0. |
Member
Author
|
Closing this in favor of #14159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #13940
The fix is implemented by locks around m_pMapping and reference counting.
The locks are either a mutex or a spin lock depending on the compiler support.
I have applied them everywhere, because it is not obvious which threads are readers and writers.
There is potential for further refactoring, because the Mapping is finally no longer shared when used. This is however out of scope of this band aid PR.