Fix warning when removing closed database connections#1394
Merged
daschuer merged 1 commit intomixxxdj:masterfrom Nov 25, 2017
uklotzde:fix_remove_database
Merged
Fix warning when removing closed database connections#1394daschuer merged 1 commit intomixxxdj:masterfrom uklotzde:fix_remove_database
daschuer merged 1 commit intomixxxdj:masterfrom
uklotzde:fix_remove_database
Conversation
Closed
Member
|
LGTM Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported here:
#1069
I simply overlooked this one among all the debug logs. It doesn't do any harm, but triggers a warning and hides potential leaking of database connections.