Skip to content

Update Reloop Beatmix 2/4 mapping to reflect new effects UI#1371

Closed
sblaisot wants to merge 2 commits intomixxxdj:2.2from
sblaisot:patch-1
Closed

Update Reloop Beatmix 2/4 mapping to reflect new effects UI#1371
sblaisot wants to merge 2 commits intomixxxdj:2.2from
sblaisot:patch-1

Conversation

@sblaisot
Copy link
Copy Markdown
Member

@sblaisot sblaisot commented Nov 4, 2017

Following changes in effects section of Deere and Tango, update the mapping on Reloop Beatmix 2/4 to control 3 effects by effect unit by default (previously single effect mode was the default).

Following changes in effects section of Deere and Tango, update the mapping on Reloop Beatmix 2/4 to control 3 effects by effect unit by default (previously single effect mode was the default).
@sblaisot sblaisot changed the title Update Reloop Beatmix 2/4 mapping to refletc new effects UI Update Reloop Beatmix 2/4 mapping to refletccnew effects UI Nov 4, 2017
@sblaisot sblaisot changed the title Update Reloop Beatmix 2/4 mapping to refletccnew effects UI Update Reloop Beatmix 2/4 mapping to reflect new effects UI Nov 4, 2017
@sblaisot
Copy link
Copy Markdown
Member Author

sblaisot commented Nov 4, 2017

@uklotzde uklotzde added this to the 2.1.0 milestone Nov 25, 2017
@sblaisot
Copy link
Copy Markdown
Member Author

sblaisot commented Dec 20, 2017

any chance to have this merged before 2.1 @Be-ing @daschuer @uklotzde ?

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Dec 21, 2017

Yes. I will review controller mappings after the beta release. Don't worry, we'll get this done in 3 months :).

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Dec 23, 2017

I will get to reviewing this soon, but for now I will be taking a break from development and code review for a few days.

@Be-ing Be-ing assigned Be-ing and unassigned Be-ing Dec 27, 2017
@Be-ing Be-ing self-requested a review December 27, 2017 16:02
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Mar 23, 2018

I took a look at the wiki and I don't think either of the modes make much sense for 2.1. At a minimum, I suggest mapping the knobs to the metaknobs and the Beats encoder to the dry/wet knob. Because this controller does not have buttons to toggle the enable switches of the effects, I suggest setting every effect to enabled in the init function. To avoid confusion when setting up like I described in #1103, you could also set the dry/wet knob to fully dry on startup.

If you want to go the extra mile and implement a way to control the parameters of effects, you could use turning the Beats encoder while holding it pushed down to switch the focus between effects.

@Be-ing Be-ing modified the milestones: 2.1.0, 2.2.0 Mar 30, 2018
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Mar 30, 2018

@sblaisot unless you have time to implement the changes in my above comment within the next day or two, let's push this back to 2.2.

@Be-ing Be-ing modified the milestones: 2.2.0, 2.1.x Apr 18, 2018
@daschuer daschuer modified the milestones: 2.1.x, 2.2.x Jan 13, 2019
@Holzhaus
Copy link
Copy Markdown
Member

What's the status of this?

@github-actions
Copy link
Copy Markdown

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions Bot added the stale Stale issues that haven't been updated for a long time. label Oct 20, 2020
@Be-ing Be-ing changed the base branch from master to 2.2 October 23, 2020 23:53
@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented Dec 3, 2020

@sblaisot Do you intend to pick this up at some point, or should we close this?

@github-actions github-actions Bot removed the stale Stale issues that haven't been updated for a long time. label Dec 4, 2020
@sblaisot sblaisot closed this Jan 1, 2021
@sblaisot sblaisot deleted the patch-1 branch January 1, 2021 17:26
@uklotzde uklotzde removed this from the 2.2.5 milestone May 11, 2021
@uklotzde uklotzde added this to the 2.3.0 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants