Denon MC7000: Unify parameter button logic and add customizable modes#13589
Merged
Conversation
fwcd
commented
Aug 22, 2024
Merged
fwcd
force-pushed
the
mc7000-parameter-buttons
branch
from
9f507c1 to
590edda
Compare
Member
Author
|
The branch is now rebased onto the latest 2.5 and the conflict from #13588 is fixed. |
Swiftb0y
reviewed
Aug 31, 2024
Swiftb0y
approved these changes
Sep 6, 2024
Member
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
LGTM. thank you. Sorry for having this dragged out this long
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #4310, which aims to refactor the logic for the customizable parameter buttons on the Denon MC7000. Currently, the buttons change the star rating (track color if shifted), but some users rarely change these and would rather wish to map them differently.
Fortunately, the new controller settings feature lets us have our cake and it eat it too. This PR unifies the parameter button, refactors the code to be more concise/readable and adds three new parameter button modes:
Change Star Rating (Shift: Track Color)Perform Beat Jump (Shift: Adjust Jump Size)Set Intro/Outro (Shift: Clear Intro/Outro)This PR also lets the user customize whether to override the parameter button mode with changing the pitch range. This is the default behavior as of #4729, which might be surprising to users that change the mode, hence the ability to disable it.