Fix wrong debug assertions#1355
Merged
daschuer merged 1 commit intomixxxdj:masterfrom Sep 28, 2017
uklotzde:empty_tags_debug_assertion
Merged
Fix wrong debug assertions#1355daschuer merged 1 commit intomixxxdj:masterfrom uklotzde:empty_tags_debug_assertion
daschuer merged 1 commit intomixxxdj:masterfrom
uklotzde:empty_tags_debug_assertion
Conversation
... when adding new files without tags to the library.
Member
|
Thank you. I ran into this recently myself, but I had no time to investigate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... when adding new files without tags to the library. The source field has already been set to GUESSED while all other fields contain default values.
Usually I don't add files without tags to the library so I didn't notice this minor regression. Can be tested by adding our test files.