(fix) avoid catching Num key modifier on macOS#13481
Merged
Merged
Conversation
Member
Author
|
Note: alternatively we could also check for Not sure if that's worth the effort. And I'm not sure whether we should explicitly check for the |
Contributor
|
I confirm the bug and the fix (I had no idea that shift left / shift right was supposed to load the track, very convenient indeed!). |
Contributor
|
Tested and works for me on MacOS, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13305
59b54da introduced a regression on macOS:
debugging in #13331 revealed that on macOS the arrow keys are sent with Num modifier, for which there would be no match in our keyseq/control hash.
Revert to checking the individual modifiers and cosntruct the QKeySequence with QStrings.