Skip to content

(appveyor) fix NSIS patch after appveyor NSIS upgrade#1344

Merged
daschuer merged 1 commit intomixxxdj:masterfrom
sblaisot:appveyor-fix-NSIS-patch
Sep 16, 2017
Merged

(appveyor) fix NSIS patch after appveyor NSIS upgrade#1344
daschuer merged 1 commit intomixxxdj:masterfrom
sblaisot:appveyor-fix-NSIS-patch

Conversation

@sblaisot
Copy link
Copy Markdown
Member

@sblaisot sblaisot commented Sep 16, 2017

Appveyor updated NSIS in their build server image on September 07, 2017 [1] so our patch to NSIS is no longer valid and all appveyor build fail since then.
This PR updates the NSIS patch to fix appveyor CI builds.

[1] https://www.appveyor.com/updates/

@sblaisot sblaisot mentioned this pull request Sep 16, 2017
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Sep 16, 2017

AppVeyor build passed 👍

@daschuer
Copy link
Copy Markdown
Member

Thank you.

Mac fails with unrelated:

Error: jpeg 8d is already installed

any idea?

@daschuer daschuer merged commit 3be7746 into mixxxdj:master Sep 16, 2017
@sblaisot sblaisot deleted the appveyor-fix-NSIS-patch branch September 16, 2017 22:56
@sblaisot
Copy link
Copy Markdown
Member Author

sblaisot commented Sep 16, 2017

Thanks @daschuer .
I will take a look at travis mac build.
either we need to upgrade jpeg to 9b before installing libjpeg or simply need to remove libjpeg as it is now pre-installed. I will try both a make a PR with the working solution.

@sblaisot sblaisot mentioned this pull request Dec 23, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants