-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ES6+ ComponentsJS #13437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
ES6+ ComponentsJS #13437
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
|
|
||
| /** ScriptConnectionJSProxy */ | ||
|
|
||
| declare interface ScriptConnection { | ||
| /** | ||
| * Disconnect the script connection, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain a little more on why you think the promise model is suited well for timers here? From what I can tell, they would only work for one-shot timers. I know
engine.beginTimeris clunky to use, but so is its direct foundation (window.setTimeout/window.setInterval) and I don't think JS overs anything better. Do you have a better idea of what constitutes a good timer API? I'm also not sure, but wasn't there a previous discussion on this already?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not aware of a previous discussion on this matter.
So the idea here is to offer a more modern and ES6+ way of using timers. Promises a particularly suited for this kind of task.
Of course, since Promises only resolve once, it makes more sense for one-shot timers. But the
cancel()method I added also handle the case where the timer was already cancelled which has the advantage of avoiding the warning when trying toengine.stopTimer()a one-shot that was already executed. This warning message really bothers me.Of course, if this is too controversial, I'll remove this. But I still think it's a nice addition.