Mixxx skin: Dark Metal#1318

Closed

daschuer wants to merge 54 commits intomixxxdj:mainfrom

daschuer:DarkMetal

Member

daschuer commented Jul 23, 2017

Mixxx skin: Dark Metal

1) 100% Scalable Vector Graphics (SVG).

• 100% Quality lossless graphics.
Not even one bitmat anywhere.

2) Fully resizable.

• Small screen users can use it too.
All elements must fit nicely in all resolutions. Please note that If your resolution is too small, some racks (rows) may overlap, even so, you can still disable their visibility (there are lots of buttons, in the top bar, for that. These buttons are always visible, no matter what, even you "enable" everything). Ready from 980x350, to infinity.

3) Mixxx features.

• Contains the lattest Mixxx features.
But!... I´m sure that not all tasks arent done, so I´m always sharping the graphics, correcting issues, adding forgotten stuff...

4) Unique features.

• Contains original and unique features.
I´ll try to add features not available (yet!...) anywhere else, they must be functional too, of course. Like the analog VUs, the digital fonts, a grey only color scheme (a fully "metallic" skin), etc, etc... Our imagination (vs. the code), will be the limit...

This skin lives here:
http://www.mixxx.org/forums/viewtopic.php?f=8&t=6052
(Lives alone... No fitable skeleton was found yet!...)

jorgerosa added 30 commits

February 9, 2017 13:03


          Create empty.txt

02d200b


          Add files via upload

dc2314c


          Create a

4deb30c


          Add files via upload

7d2c073


          Add files via upload

13133fa


          Delete a

22076d6


          Add files via upload

264493e


          Add files via upload

88e4d16


          Update README.md

cdcee4c


          Delete README(2).txt

83e8a00


          Update README.md

4a88dfb


          Update README.md

7a292a4


          Update README.md


          Update README.md

a2a2898


          Update README.md

11db85a


          Delete empty.txt

648d125


          Add files via upload

bf8d8d5


          Add files via upload

1f893c3


          Add files via upload

42abc50


          Add files via upload

c6362a0


          Update README.md

a00e1fc


          Add files via upload

f5e177f


          Add files via upload

9e5c883


          Add files via upload

2b52979


          Add files via upload

f4e65a2


          Add files via upload

1f165b0


          Add files via upload

e3131e0


          Add files via upload

7adb3d3


          Add files via upload

ba864a4


          Add files via upload

585c802

Be-ing modified the milestones: 2.2.0, stalled

Contributor

Be-ing commented Jun 7, 2018

There is not time to adequately review this before the 2.2 feature freeze.

Member Author

daschuer commented Jun 7, 2018

Nice, nice, nice.

The Master Volume buttons looks a bit lifted. It would be cool as if they where looking halve way out of a convex metal plate ...

I experience also a crasher when switching maximized effects. I assume that is unrelated to this PR
I will file a bug.


          Update 02 June 2018

12a93c7

1: Added the new Laptop Battery indicator. (NOT functional, since it is not compiled with Mixxx yet)
2: Added the new "recording time" indicator.
3: Corrected colors for the #AARRGGBB color format. (Noticeable in the waves)
4: Added "star rating" in the main (big) decks.
5: Added the new "effect selector" (QComboBox) in the effects. (Click in the effect name)
6: Added button to show/hide the vinyl controls. (Per deck/channel. Because it seems that many people just dont use it)
7: Added button for "quick effect". (Per deck/channel, in the main (big) decks)
8: Added the "Beat Jump" and "Beat Loop" options.
9: Changed channels texts from "AB","CD" to "12","34". (Requested by users)
10: Added the "cover art", in the small buttons row. (Placed on decks. Helps me a lot, because it "drag-n-drop" feature)
11: Added options to select by module on the "Mics", "Aux" and at "Long Waves".
12: GUI was re-designed (Excessive/Confusing buttons. Much more user-friendly/intuitive GUI by now). And now it works great on vertical monitors, too.
13: All resources were optimized (~300Kb less).
14: Big Decks and Mini Decks can now move partially too. (Done by a Splitter)
15: Beat Sync in the mixer. (Between the Big Decks)
16: Fixed many many other small (minor) issues.
17: Strobes were added! (Experimental yet - Works great with music beats... BUT only after "Gains" from 8.0 and plus on most musics...
I will try to do it better using <transform> or any other trick, but will be hard ... ... ... )
18: Possibility to display your own logo (Edit any file "logo_x.svg", located inside the "graphics-logos" folder, then edit "mylogo"´s value at "skin.xml" file)
19: Added all the 64 Samplers.
20: Added music drop areas, for all decks, in the library toolbar (Specially handy when the library is in full view mode)
21: Added tooltips (Will be a progressive work...)
22: Added ducking to the microphones
23: Added all beat and grid options (Small buttons. Visible in Big Decks)
24: Added all key options (Small buttons. Visible in Big Decks)

daschuer force-pushed the DarkMetal branch from 94154d0 to 12a93c7 Compare

June 7, 2018 18:36

ghost commented Jul 21, 2019 •

edited by ghost

Loading

Hi daschuer and everyone, here is a new modified DarkMetal "styles.qss" I've just made, as I've been purposed on the mixxx forum.
Thanks to let me know if you're interesting.
Greetings.
styles.txt

daschuer added 3 commits

July 23, 2019 08:53


          Merge remote-tracking branch 'upstream/master' into DarkMetal

623ea8b


          Update 12 June 2018

04c110e


          Added styles.qss changes for HiDpi Scaling provided by alex-or-dc

4684e9f

Member Author

daschuer commented Jul 24, 2019 •

edited

Loading

@alex-or-dc I have just added your change. You may do such things yourselves if you like.
Here is a description https://www.mixxx.org/wiki/doku.php/using_git

I have also noticed that the skin has no preview image. If you like you can create them.
We need a image per color schema. See Shade skin.
Maybe it is time to consolidate the number of color schemas in turn ..

ghost commented Jul 25, 2019 •

edited by ghost

Loading

Hi, thank you very much ! it's great that it's now added ! I'll think about use the pull request, but I'm not used to upload it...At this time I've noticed a sound volume bug when switching off an effect plugin, it was reducing the original volume value on the track. I've made an extended XML file wich should resolve the bug. I join the package with the comment...Would you consider to add these XML to the DarkMetal skin, main folder ?
THX !
Greetings.
styles_xml.zip


          Added sound volume fix provided by alex-or-dc

bfc7080

ghost commented Dec 5, 2019

Hi Daschuer, and everyone, I've made a global patch reworking and improvement for both systems Linux and Windows, I'd like to post it on this page, do you also take updates for Windows ?
I'm still not used to setting up git for the pull request..
Waiting for your answer, I hope this page is 100% designed about both systems.

Member Author

daschuer commented Dec 6, 2019

Don't hesitate to send it to me.
I think this skin is equal on all OSs.
What was you issue on Windows?

Contributor

Be-ing commented Dec 6, 2019

I'm still not used to setting up git for the pull request..

This concerns me. Please understand that adding a new skin multiplies the work required to maintain Mixxx for every new feature that gets added in the future; it is not something that gets done once and then can be left alone. I am not comfortable merging this or even starting to review it unless we have someone who commits to maintaining the skin into the future and that requires using Git. IMO it is not reasonable to ask us to go out of our way to take the code you send us for every little change via ZIP file and put it into Git. That would be a lot of tedious extra work that we don't do for anyone else. We have a guide to help you start with Git and you can ask for help on Zulip if you have questions.

Member

ronso0 commented Dec 6, 2019

... and from what I recall from my last review a lot needs to be done to make DarkMetal somehow conform to how the other skins work. Clean up & rename skin COs, tune effect controls etc.

ghost commented Dec 6, 2019

ok no worries, I've removed the post at all. I was thinking I could work this way because of the communautary aspect of Linux and the software, I'm just a beginner, congratulation Mixxx is a great software !

Member

ronso0 commented Dec 6, 2019

@alex-or-dc
I see there's a DarkMetal fan base, and I guess that's the reason why @daschuer opened this PR.
I bet you've invested hundreds of hours into DarkMetal (like I did for Tango). It takes like 5min to set up git and another let's say 30min to read the git tutorial, maybe watch a few intro videos, to get used to the basic git commands. Then you'd be ready to open your own PR to add DarkMetal to Mixxx. The rest will learning-by-doing.
I think this way everyone interested in DarkMetal will benefit: the users because they'd get a skin that's working with latest Mixxx features and also working well when switching between official Mixxx skins, also Mixxx devs will support you solving skin issues.


          Merge remote-tracking branch 'upstream/master' into DarkMetal

af486bf

Member Author

daschuer commented Dec 6, 2019

I did a download of your preview zip before you have removed it.

There are two folders Linux and Windows with only marginal changes.
Normally we try to find one setting that fits all.
You changes itself are looking really interesting.
A before / after screenshot would be nice.

The preview in the preference is quite big can you reduce it to a height of 250 pixel?

I can add you changes here so they are not lost, but if you issue a PR to https://github.com/mixxxdj/mixxx/tree/DarkMetal
that would be much better.

Contributor

Be-ing commented Dec 7, 2019

You're welcome to participate in the Mixxx community, but if you want to contribute code, you have to use the tools that the community uses. As @ronso0 said, learning to use Git is probably way less work than you have already invested in working on this skin.

github-actions Bot commented Oct 20, 2020

This PR is marked as stale because it has been open 90 days with no activity.

github-actions Bot added the stale label

Be-ing changed the base branch from master to main

October 23, 2020 23:53

ronso0 marked this pull request as draft

November 20, 2020 10:18

Member

Holzhaus commented Apr 2, 2021

I don't think we should add yet another DJ skin to Mixxx without removing one (notable exception: Broadcasting skin). Otherwise we have too many builtin skins that we need to maintain.

Contributor

Be-ing commented Apr 2, 2021

I agree. Let's close this old unmaintained PR.

Be-ing closed this

mixxxbot mentioned this pull request

QT5: Crash when switching Big effects in Dark Metal #9332

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels