S4MK3: Software mixer support and default pad layout customisation#13059
Conversation
| default="false" | ||
| label="Main gain is handled by the Mixxx built-in mixer"> | ||
| <description> | ||
| When enable, the master potentiometer on top right column of the mixer will drive the main gain of the Mixxx internal mixer as well as the hardware built-in mixer in the device. This is useful if you aren't relying on the hardware output, but will create conflict if enabled when using the hardware outputs. |
There was a problem hiding this comment.
Not sure if the word master is problematic here - the device is physically labelled with Master so if it is, perhaps I can put " around it or the :hwbtn: marker?
|
Really annoying that the |
acolombier
force-pushed
the
feat/s4-mk3-external-mixer
branch
from
7ba20c8 to
0afe2dc
Compare
|
Merge? |
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
ywwg
left a comment
ywwg
left a comment
There was a problem hiding this comment.
small suggestion for wording, otherwise looks good
Co-authored-by: Owen Williams <owen-github@ywwg.com>
|
As the manual PR has been merged now, are we happy to merge this one too? |
|
Can someone from the Core Team add the 2.5 milestone on this PR? The manual for this was merged so that will have to go with it (or need revert on manual) |
|
I should be able to quickly test this on my hardware and merge today if it's good |
4 participants
This addresses two feature requested raised on Zulip
UI change:
Before:
After:
