Computer feature: add sidebar action "Refresh directory tree"#12908
Merged
Conversation
ronso0
force-pushed
the
browse-refresh-dir-tree
branch
from
cbfcac7 to
e943a72
Compare
remove cached 'hasChildren' state for all sub-dirs in order to allow expanding items that have sub-dirs added after the items have been shown the first time.
ronso0
force-pushed
the
browse-refresh-dir-tree
branch
from
e943a72 to
9e6b543
Compare
daschuer
requested changes
May 1, 2024
Member
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
I did the following:
- Opened a folder with Mixxx
- Added a file using a file manager.
- Select Refresh form the context menu.
Expected: File is shown
Actual: nothing happens.
Member
|
Refreshing the folders works. The menu is missing for "Quick access" folders |
Member
|
I have also intuitive pressed F5, but that has a different meaning. |
Member
Author
I added that. |
Member
Author
|
Yeah, F5 in the tracks view would also be cool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to show newly added directories when the parent had no directories when it was first added to the tree.
This works around the caching of the 'hasChildren' state of each tree item.
based on #12893