feat(qml): Add dummy QML library sidebar#12897
Draft
Holzhaus wants to merge 1 commit into
Draft
Conversation
acolombier
reviewed
Mar 22, 2024
Member
acolombier
left a comment
acolombier
left a comment
There was a problem hiding this comment.
Looks like there is some overlap on the work I'm doing with QML library, forked from your other QML Library (stale?) PR.
I couldn't test it currently since there is a missing component:
warning [Main] QQmlApplicationEngine failed to load component
warning [Main] file:///.../mixxx/res/qml/main.qml:158:9: Type Skin.Library unavailable
warning [Main] file:///.../mixxx/res/qml/Library.qml:38:13: LibrarySidebar is not a type
I'd be in favour of getting this ready to merge ASAP, even incomplete, so I don't duplicate effort too much on my side
|
|
||
| SplitView.preferredWidth: 200 | ||
|
|
||
| LibrarySidebar { |
Member
There was a problem hiding this comment.
Looks like this component is missing - forgot to stage a QML file perhaps? :)
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
Bot
added
the
stale
github-actions
Bot
removed
the
stale
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
Bot
added
the
stale
github-actions
Bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tree items are not functional, but the tree is displayed and can be expanded/collapsed.
Screencast.from.2024-02-29.22-38-15.webm