Skip to content

View menu: add 'Show Auto DJ' action#12890

Merged
daschuer merged 3 commits into
mixxxdj:mainfrom
ronso0:autodj-show-menu-action
Sep 1, 2025
Merged

View menu: add 'Show Auto DJ' action#12890
daschuer merged 3 commits into
mixxxdj:mainfrom
ronso0:autodj-show-menu-action

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Feb 28, 2024

requested here https://mixxx.zulipchat.com/#narrow/stream/109122-general/topic/AutoDJ.20as.20a.20View.20option

AutoDJ is a special feature that may need immediate attention, i.e. a way to activate it quickly, that's why I think a shortcut seems reasonable.
Screenshot_2024-02-28_13-21-01

Which keyboard shortcut?

There are already Ctrl+1..6
Ctrl+7 would be next, but maybe we want to extend the skin controls, and then it would be better to have consecutive shortcuts for toggles ("Show AutoDJ is a trigger).
What about Ctrl+9?

@fwcd
Copy link
Copy Markdown
Member

fwcd commented Feb 28, 2024

Maybe adding the other "main" sections would make sense too, e.g. "Show Tracks"?

I'd probably lean towards a non-numeric shortcut so we can reserve those for skin controls and go for a letter (e.g. Ctrl + Alt or Shift + A?)

@ronso0 ronso0 force-pushed the autodj-show-menu-action branch from c63da3c to 778c5e8 Compare February 29, 2024 00:29
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Feb 29, 2024

have to reconsider this:
IIUC the idea was to quickly jump to AutoDJ when you're way down in the sidebar.
Currently this action selects AutoDJ but also scrolls there.

However, since you (maybe) only want to activate AutoDJ and then continue working in the last view (computer, history, ...), it would be helpful if the position of the sidebar were fixed. Sure, the current view would be deselected, but it would still be easy to pick up where you left off.
With Tracks or other views it could be confusing, but the AutoDJ view is recognizable.

What do you think?

Maybe adding the other "main" sections would make sense too, e.g. "Show Tracks"?

And we'd have #9912 (somehow) : )

Comment thread src/library/autodj/autodjfeature.cpp Outdated
@daschuer
Copy link
Copy Markdown
Member

Works already :-)

@daschuer
Copy link
Copy Markdown
Member

However, since you (maybe) only want to activate AutoDJ and then continue working in the last view (computer, history, ...), it

Correct. I played a bit with it and it reminds me to taped browsing. Search for something in the Library, verify the Auto-DJ playlist.
Continue searching.

We may emulate that by adding tabs to the sidebar ... Or a back button.

The ultimate solution "Open Auto DJ in a new Window" We have discussed the idea earlier to have a skin with two windows.

Or even allow to have two or more tabs on the library. This will allow to switch between any two contexts without headaches.

@daschuer
Copy link
Copy Markdown
Member

I get hocked to the tapped library idea. Can we implement it with the singleton library feature in two tabs? In a first version each tap "just" need to restore the stored library table. Caveat: We cant have two tabs with the same playlist open and a saved state for each.

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Feb 29, 2024

Yes, these are nice ideas and part of the library redesign discussion.
I'm not going ot work on it : )

Here, I think we are good if we simply add something like SidebarModel::selectFeatureNoScroll(LibraryFeature* pFeature). Though this will inevtably be mostly redundant with the existing selectFeature, hmm.

@vespadj
Copy link
Copy Markdown
Contributor

vespadj commented Mar 13, 2024

My suggestion
AutoDJ in Tray bar

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Mar 13, 2024

Thank you, having a (additional*) topbar toggle is a good idea!
*Shade skin has no top bar, so we should always provide the action in the View menu

Note: moving widgets out of the top bar is out of scope here.
There is WIP regarding a global status bar though #3406

@github-actions
Copy link
Copy Markdown

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions Bot added the stale Stale issues that haven't been updated for a long time. label Jun 12, 2024
@ronso0 ronso0 force-pushed the autodj-show-menu-action branch from 778c5e8 to dfdbd59 Compare July 29, 2024 11:20
@github-actions github-actions Bot removed the stale Stale issues that haven't been updated for a long time. label Jul 30, 2024
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Jan 26, 2025

I think I will pick parts of this to fix #13512

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2025

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions Bot added the stale Stale issues that haven't been updated for a long time. label May 1, 2025
@vespadj
Copy link
Copy Markdown
Contributor

vespadj commented May 5, 2025

UP

@ronso0 ronso0 force-pushed the autodj-show-menu-action branch from dfdbd59 to f136c9c Compare May 5, 2025 10:12
@ronso0 ronso0 marked this pull request as ready for review May 5, 2025 10:12
@ronso0 ronso0 removed the stale Stale issues that haven't been updated for a long time. label May 5, 2025
Copy link
Copy Markdown
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Thank you. One clazy hint.

Comment thread src/mixxxmainwindow.cpp Outdated
@ronso0 ronso0 force-pushed the autodj-show-menu-action branch from f136c9c to 3c508f3 Compare September 1, 2025 10:19
@daschuer
Copy link
Copy Markdown
Member

daschuer commented Sep 1, 2025

Thank you. The CI Failure is unrelated.

Copy link
Copy Markdown
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer daschuer merged commit 26ca619 into mixxxdj:main Sep 1, 2025
15 of 16 checks passed
@ronso0 ronso0 deleted the autodj-show-menu-action branch September 1, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants