Skip to content

Fix and improve Logging & Debugging#1265

Merged
daschuer merged 3 commits intomixxxdj:masterfrom
uklotzde:logging_and_debugging
May 25, 2017
Merged

Fix and improve Logging & Debugging#1265
daschuer merged 3 commits intomixxxdj:masterfrom
uklotzde:logging_and_debugging

Conversation

@uklotzde
Copy link
Copy Markdown
Contributor

@uklotzde uklotzde commented May 25, 2017 •
edited
Loading

  • Remove cross-module static initialization dependencies between CmdLineArgs and ControllerDebug
  • Untangle dependencies between Logging and ControllerDebug
  • Pull log levels into mixxx namespace and add a default value to the enum
  • Provide access to the current log level for conditional log message formatting at runtime

@daschuer
Copy link
Copy Markdown
Member

daschuer commented May 25, 2017

LGTM! Thank you.

@daschuer daschuer merged commit 57be954 into mixxxdj:master May 25, 2017
@uklotzde uklotzde deleted the logging_and_debugging branch June 12, 2017 06:37
@radusuciu
Copy link
Copy Markdown
Contributor

radusuciu commented Jun 21, 2017

Is it possible to have a summary of changes to logging options on the wiki?

https://www.mixxx.org/wiki/doku.php/command_line_options

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Jun 21, 2017

Done! Thank you for the reminder.

esbrandt added a commit to esbrandt/manual that referenced this pull request Jun 24, 2017
@esbrandt
Adds latest additions and changes to command line options.
431b5ad 
``--debugAssertBreak``
``--logLevel``
``--controllerDebug``
mixxxdj/mixxx#1265
mixxxdj/mixxx/mixxxdj#118
mixxxdj/mixxx#1004
@esbrandt esbrandt mentioned this pull request Jun 24, 2017
Merged
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uklotzde @daschuer @radusuciu