sync phaser period to tempo by Be-ing · Pull Request #1261 · mixxxdj/mixxx

Be-ing · 2017-05-15T01:58:04Z

Tempo sync all the temporal effects!

Depends on:

sync echo effect to BPM #1256

daschuer · 2017-05-15T22:01:49Z

-        pOutput[i] = pInput[i] * (1.0 - 0.5 * depth) + left * depth * 0.5;
-        pOutput[i + 1] = pInput[i + 1] * (1.0 - 0.5 * depth) + right * depth * 0.5;
+        pOutput[i] = pInput[i] + left * depth * 0.5;
+        pOutput[i + 1] = pInput[i + 1] + right * depth * 0.5;


Unlike Reverb, the Phaser can be used as an insert effect. Since it has no delay component, you can turn it into a kind of insert effect by using the dry wet knob only. After this change, this is not possible any-more.

How about issue the "not loud enough" problem by a special scale for depth:
-> left half, new scale: up to 100 % dry + 50 % phaser
-> right half: up to 0% dry + 100 % phaser

I do not understand the issue nor your proposal here. I have added a new commit turning this into a send effect. I think it works well. Please test this approach.

I implemented a new way to mix the input and output signals. I think it (somewhat?) matches your proposal. The depth knob acts similar to a dry/wet knob, but because the wet signal is formed by adding two samples, it is divided by 2 before mixing with the dry signal. With the new formula, the input signal is unaffected when the depth knob is all the way down and the volume does not increase when the depth knob is all the way right, but the sound of the effect is clearly audible. However, it is a bit difficult to hear in the middle. I'll play with this more and if it works well I'll try implementing it in #1257 for the Flanger effect too.

daschuer · 2017-05-15T22:10:31Z

+    } else {
+        // Period is a number of seconds
+        // TODO: remove assumption of stereo signal
+        period = period * sampleRate * 2;


My tracks have a much higher average BPM. Did you consider to pick 120 bpm to have similar scales?
It looks like this decision is a common one among all beat synced effects.
Can we define this somewhere central?

How about pick a reasonable clock in this case, like the other deck bpm or the master clock?
This is probably out of the focus of this PR.

Picking any BPM would be totally arbitrary and inappropriate for a lot of music. Using the master clock would make sense, but the effects system does not provide that information currently. Only information about the channel being processed is available to the effect.

daschuer · 2017-05-16T05:35:21Z

I have tested it. I think the phase works also well as insert effect, if you wish to fade into some kind of of sytesizer noise. If we merge this at it is we loose this kind of sound. My proposal is to have both. From fully left to mid the behaviour you have implemented here. If you turn to the second half it may turn to a 100 % dry effect. Lowering the input signal to 0 I'm the master version it is only 50 % right now.

Be-ing · 2017-05-16T12:36:48Z

If you turn to the second half it may turn to a 100 % dry effect.

I don't understand why you want that. The effect's sound comes from mixing the dry signal with the phase shifted wet signal to create interference. Without the dry signal there is no audible change, unless the dry signal is reintroduced by turning down the chain's dry/wet knob. Changing how the effect interacts with the dry/wet knob half way through the metaknob is counterintuitive and inconsistent with how other effects work, which would be strange in a chain.

Be-ing · 2017-07-31T05:11:50Z

+        // the dry and computed sample, so to avoid making the output louder, divide
+        // the wet signal by 2.
+        pOutput[i] = pInput[i] * (1.0f - depth)
+                   + (pInput[i] + left) / 2.0f * depth;


I think this works quite well except that it is difficult to hear before the depth knob is up half way. I think changing the curve of the parameter to some sort of logarithmic curve could solve that issue, but I don't quite understand the math behind ControlLogPotmeterBehavior or ControlAudioTaperPotBehavior. @daschuer do you have any ideas for how to improve the scaling?

Be-ing · 2017-07-31T06:47:51Z

I rebased this on master to remove the commits related to the Depth parameter and keep this PR focused on syncing the period to the tempo. Work on the Depth parameter continues in #1326.

Be-ing · 2017-09-26T04:06:05Z

I have added a Triplet parameter and adjusted the parameter defaults, ranges, and ordering a bit. I tried adding a Quantize parameter like Echo, but unlike Echo, I don't think there is a use case for an unquantized Phaser period.

daschuer · 2017-10-03T21:18:31Z

+                * sampleRate * kChannels;
+    } else {
+        // period is a number of seconds
+        period = std::max(period, 1/4.0) * sampleRate * kChannels;


remove kChannels here, it is applied twice

daschuer · 2017-10-03T21:18:50Z

+            period /= 3.0;
+        }
+        period = period * groupFeatures.beat_length_sec
+                * sampleRate * kChannels;


remove kChannels here, it is applied twice

daschuer · 2017-10-03T21:19:27Z

+    period->setUnitsHint(EffectManifestParameter::UnitsHint::BEATS);
+    period->setMinimum(0.0);
+    period->setMaximum(4.0);
+    period->setDefault(0.5);


this should be 1

Be-ing · 2017-10-08T05:02:13Z

Notes addressed.

daschuer · 2017-10-08T21:23:43Z

Thank you!

Be-ing mentioned this pull request May 15, 2017

sync flanger period to tempo #1257

Merged

1 task

daschuer reviewed May 15, 2017

View reviewed changes

ronso0 mentioned this pull request Jun 9, 2017

move effects post-fader #1254

Merged

2 tasks

Be-ing commented Jul 31, 2017

View reviewed changes

Be-ing force-pushed the tempo_sync_phaser branch from 8e61cda to 5c79a9c Compare July 31, 2017 06:13

Be-ing force-pushed the tempo_sync_phaser branch from 5c79a9c to b2028a1 Compare September 17, 2017 00:28

Phaser: replace Rate parameter with Period synced to tempo

b3ea852

Be-ing force-pushed the tempo_sync_phaser branch from b2028a1 to b3ea852 Compare September 17, 2017 02:03

Be-ing added 4 commits September 25, 2017 15:47

Merge remote-tracking branch 'upstream/master' into tempo_sync_phaser

45fbc47

Phaser: add Triplet parameter

1dfd87d

Phaser: use full frequency range by default

a4118c8

Phaser: rearrange parameters

9a5dc06

Phaser: fix Triplet parameter description

3d875ea

daschuer reviewed Oct 3, 2017

View reviewed changes

Phaser: fix scale of Period parameter

2d12ef1

daschuer merged commit 335f24d into mixxxdj:master Oct 8, 2017

Be-ing deleted the tempo_sync_phaser branch October 8, 2017 21:30

mixxxbot mentioned this pull request Aug 22, 2022

BPM Sync for effects #8312

Closed

Uh oh!

Conversation

Be-ing commented May 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daschuer May 15, 2017

Choose a reason for hiding this comment

Uh oh!

Be-ing May 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Be-ing Jul 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daschuer May 15, 2017

Choose a reason for hiding this comment

Uh oh!

Be-ing May 15, 2017

Choose a reason for hiding this comment

Uh oh!

daschuer commented May 16, 2017 via email

Uh oh!

Be-ing commented May 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Be-ing Jul 31, 2017

Choose a reason for hiding this comment

Uh oh!

Be-ing commented Jul 31, 2017

Uh oh!

Be-ing commented Sep 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daschuer Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

daschuer Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

daschuer Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

Be-ing commented Oct 8, 2017

Uh oh!

daschuer commented Oct 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Be-ing commented May 15, 2017 •

edited

Loading

Be-ing May 16, 2017 •

edited

Loading

Be-ing Jul 4, 2017 •

edited

Loading

Be-ing commented May 16, 2017 •

edited

Loading

Be-ing commented Sep 26, 2017 •

edited

Loading