Components: make EffectUnit.enableButtons Power Window buttons#1249
Merged
daschuer merged 1 commit intomixxxdj:masterfrom May 7, 2017
Merged
Components: make EffectUnit.enableButtons Power Window buttons#1249daschuer merged 1 commit intomixxxdj:masterfrom
daschuer merged 1 commit intomixxxdj:masterfrom
Conversation
Short press for latching toggle, long press for momentary toggle
Member
That was my thing, because the button behaves just like my cars power window and that was a very handy term to describe the behaviour in two words. |
Member
|
LGTM! |
Contributor
Author
Heh, okay. Maybe we can think of a more self-explanatory term in the future. I have only played with this briefly, but it is fun. It facilitates turning effects on and off rhythmically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short press for latching toggle, long press for momentary toggle like in skins. Any Button can easily be set to behave the same way by setting its
powerWindowproperty totrue. There are no changes to the public API of EffectUnit.Why is this called a "power window"? Where did that name come from?