Skip to content

Components: make EffectUnit.enableButtons Power Window buttons#1249

Merged
daschuer merged 1 commit intomixxxdj:masterfrom
Be-ing:components_powerwindow_button
May 7, 2017
Merged

Components: make EffectUnit.enableButtons Power Window buttons#1249
daschuer merged 1 commit intomixxxdj:masterfrom
Be-ing:components_powerwindow_button

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented May 7, 2017

Short press for latching toggle, long press for momentary toggle like in skins. Any Button can easily be set to behave the same way by setting its powerWindow property to true. There are no changes to the public API of EffectUnit.

Why is this called a "power window"? Where did that name come from?

Short press for latching toggle, long press for momentary toggle
@daschuer
Copy link
Copy Markdown
Member

daschuer commented May 7, 2017

Why is this called a "power window"? Where did that name come from?

That was my thing, because the button behaves just like my cars power window and that was a very handy term to describe the behaviour in two words.
My current car has a button with two pressure thresholds though :-/

@daschuer
Copy link
Copy Markdown
Member

daschuer commented May 7, 2017

LGTM!

@daschuer daschuer merged commit 6904844 into mixxxdj:master May 7, 2017
@Be-ing Be-ing deleted the components_powerwindow_button branch May 7, 2017 15:11
@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented May 7, 2017

That was my thing, because the button behaves just like my cars power window and that was a very handy term to describe the behaviour in two words.

Heh, okay. Maybe we can think of a more self-explanatory term in the future.

I have only played with this briefly, but it is fun. It facilitates turning effects on and off rhythmically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants