Svg color schema fixes#1248
Conversation
…ave a colour schema
| } else { | ||
| m_pSvg->load(source.getData()); | ||
| } | ||
| if (mode == TILE || mode == Paintable::FIXED || WPixmapStore::willCorrectColors()) { |
There was a problem hiding this comment.
This change converts all FIXED SVGs to raster? Won't this cause blurry SVGs on hidpi displays?
There was a problem hiding this comment.
Fixed in the latest commit.
|
No, because it creates a 1:1 target pixmap. It was done this way before, this PR move the code a bit around to make it more obvious. For qt5 this will indeed an issue if we not consider the device pixels ... a topic for Mixxx 2.2. |
Do you mean it's ok because scaleFactor scales the target pixmap to 2x? That's not the case if you are either using Qt5 or are on macOS on Qt4. |
Yes. But I was not aware, that macOs already does the scaling. I now remember that we have enabled it for 2.0 at a time. How plays the new scale factor on MacOs? Unfortunately I cannot test it. Would you mind to adopt this issue and propose a solution for MacOS? |
|
@Be-ing the concerns from RJ are issued. Can you pleas have a loop if it works for you? |
|
I tested with #1179 and it looks good to me. I can't test whether scaling looks good on Mac though. |
|
Ok then I will merge it and hope (or actually hope not) we master receive test results form Mac user. |
3 participants
This fixes some remaining issues with SVGs, color schemes and scaling.
Now the DarkMetal skin looks nice again.
Fixes https://bugs.launchpad.net/mixxx/+bug/1686663
This includes also some refactoring to remove old unused code.