Components SyncButton and PlayButton changes#1244
Merged
daschuer merged 3 commits intomixxxdj:masterfrom May 6, 2017
Merged
Conversation
and use shift + sync for toggling quantize. Few controllers have a dedicated button for toggling quantize, but it is useful to have accessible on a controller.
Keeping a track in reverse can be a useful mixing tool: http://djtechtools.com/2017/03/27/use-reverse-cdjs-creative-dj-mixes/
Contributor
Author
|
Any thoughts? Ready for merge? |
Member
|
LGTM! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make SyncButton behave like it does in skins. Short press uses beatsync, long press uses sync_enabled. Shift + sync toggles quantize.
Change shift + PlayButton to toggle reverse mode instead of activating reverse only while the buttons are held down. Mapping reverse this way can be useful for mixing.