Pioneer DDJ-SX mapping by DJMaxergy · Pull Request #1233 · mixxxdj/mixxx

DJMaxergy · 2017-04-08T16:02:42Z

First final version of a controller mapping for the Pioneer DDJ-SX controller.

…eerDDJSX_mapping

sblaisot · 2017-04-08T16:11:36Z

Thank you for submitting this mapping. Please also update windows uninstaller : https://www.mixxx.org/wiki/doku.php/contributing_mappings#windows_installer_update

Be-ing · 2017-04-09T19:16:11Z

Thanks again for submitting this. As you may have noticed, we have a bit of a backlog of pull requests we're trying to wrap up for Mixxx 2.1, so it may be a little while before I get around to reviewing this.

radusuciu · 2017-04-10T18:29:17Z

+///////////////////////////////////////////////////////////////
+
+PioneerDDJSX.init = function(id) {
+    PioneerDDJSX.syncRate = 0;


I believe you can use this here, and in many other places instead of repeating PioneerDDJSX.

I'm not sure if this works in the init and shutdown functions. I think this might be forcibly set to the global object for those functions, but I'd have to test.

@radusuciu : I changed the code according to your remarks! Sorry, but I didn't knew it better concerning hasOwnProperty, but now I know it!
I tried this, but in the most cases it won't work. So I don't use it, with PioneerDDJSX I'm safe.

radusuciu · 2017-04-10T18:33:35Z

+
+PioneerDDJSX.blinkAutodjState = 0;
+
+PioneerDDJSX.vuMeterTwinkle = function() {


Quite a bit of repetition in this function, could be simplified imo.

radusuciu · 2017-04-10T18:35:00Z

+    }
+
+    for (index in PioneerDDJSX.selectedLoopIntervals[deck]) {
+        if (typeof index === "string") {


Don't we usually want to use hasOwnProperty here?

radusuciu · 2017-04-10T18:42:49Z

+    }
+};
+
+PioneerDDJSX.parameterLeft = function(channel, control, value, status, group) {


Lots of duplication between parameterLeft and parameterRight functions. May be worth merging them into a single method and passing, or calculating the appropriate bit values to use.

@radusuciu

…comment @radusuciu), replaced if statement (typeof index === „string“) for property validation with hasOwnProperty (comment @radusuciu), separated and combined code of PioneerDDJSX.parameterLeft() and PioneerDDJSX.parameterRight() into new function PioneerDDJSX.changeParameters() (comment @radusuciu), the keyword „this“ does not work in most cases, so it isn’t used. Pioneer DDJ-SX.midi.xml: corrected info header.

Be-ing · 2017-04-11T16:06:47Z

+    }
+};
+
+PioneerDDJSX.softTakeoverEmulation = function(unit, index, currentValue) {


engine.softTakeover was fixed with engine.setParameter in #1065, so you should be able to remove this now.

Sorry, but I don't really understand that...can you explain it a bit? I tried engine.setParameter but it jumps to actual fader/knob value instead of take it over if I reach the in mixxx existing value (softTakeover).

I thought I need engine.softTakeover in both cases, if I use engine.setParameter or engine.setValue. Do you mean that I should prefer engine.setParameter?

I accidentally made the comment on the wrong line of code. I meant to say you can remove your PioneerDDJSX.softTakeoverEmulation function.

Yes, you do need engine.softTakeover for both engine.setValue and engine.setParameter. In Mixxx 2.0, there was a bug that made engine.softTakeover not work when engine.setParameter was used, but is fixed in the master branch and will be in Mixxx 2.1. Note you need to call engine.softTakeoverIgnoreNextValue when switching what the potentiometer controls, as documented on the wiki.

radusuciu · 2017-04-12T21:02:17Z

        offset = 0,
        samplerIndex = 0;
+
+    //Roll Mode:


Inconsistent spacing in this section, use 4 spaces to indent.

Sorry, that came from the recently made changed. I will correct that!

DJMaxergy · 2017-04-13T08:17:52Z

As I just read over this, should I replace engine.connectControl by engine.makeConnection ?

Be-ing · 2017-04-13T14:34:04Z

As I just read over this, should I replace engine.connectControl by engine.makeConnection ?

If what you have is working for your purposes, you don't need to rewrite it.

Be-ing · 2017-04-13T14:36:04Z

I see this controller uses 14 bit MIDI for the effects knobs. I'll add support for this in #1227 and #1211, but I don't have any controllers that use 14 bit MIDI myself, so I'd need someone else to test if it actually works.

Be-ing

Overall this looks quite good. Thanks for making it easy to review. :)

There will be things to change with the looping and effects controls when #1187 and #1211 are merged. You don't need to rewrite this using the Components library just to use the EffectUnit object from the library. If you choose to rewrite the rest using Components, it would make this enormous JS file more manageable.

Be-ing · 2017-04-14T04:12:43Z

+
+    // show Sampler Load configuration file dialog:
+    if (PioneerDDJSX.samplerShowLoadDialog) {
+        script.toggleControl("[Sampler]", "LoadSamplerBank");


Samplers persist across restarts now that #1213 has been merged, so remove this option.

I remove this.

Be-ing · 2017-04-14T04:14:18Z

+    // switch on Effect Units as default:
+    for (var index in PioneerDDJSX.fxUnitGroups) {
+        if (PioneerDDJSX.fxUnitGroups.hasOwnProperty(index)) {
+            engine.setValue(index, "enabled", true);


EffectUnits are on by default, so this is unnecessary.

To be save, it was implemented here, but you're right. I remove this.

Be-ing · 2017-04-14T04:15:07Z

+
+PioneerDDJSX.shutdown = function() {
+    PioneerDDJSX.setNonDeckSoftTakeover(false);
+    PioneerDDJSX.bindNonDeckControlConnections(false);


Mixxx takes care of this, so you can remove the above two lines.

I already guessed something like that, it remained here to be save. But I remove these lines now.

Be-ing · 2017-04-14T04:49:38Z

+    var fullValue = (PioneerDDJSX.highResMSB[group].filterHigh << 7) + value;
+    engine.setValue(
+        group,
+        "filterHigh",


The filterLow/Mid/High ControlObjects for EQs were deprecated in Mixxx 2.0 when the EQs were rolled into the effects system.

I replace these ControlObjects by the new EqualizerRack1 objects.

Be-ing · 2017-04-14T04:51:56Z

+        PioneerDDJSX.chFaderStart[channel] !== null
+    ) {
+        engine.setValue(group, "play", 0);
+        engine.setValue(group, "playposition", PioneerDDJSX.chFaderStart[channel]);


Neat! If I understand this correctly, you can hold shift and move the fader up briefly to use the deck like a short sample repeatedly?

Yes, you're right ;)

Be-ing · 2017-04-14T04:53:25Z

+
+PioneerDDJSX.crossfaderCurveKnobLSB = function(channel, control, value, status, group) {
+    var fullValue = (PioneerDDJSX.highResMSB[group].crossfaderCurveKnob << 7) + value;
+    script.crossfaderCurve(fullValue, 0x00, 0x3FFF);


On some controllers I think the crossfader adjustment knob changes the MIDI signals the crossfader sends. I guess that isn't the case for this controller?

Oh, I didn't consider that until now. I will check this!

After checking this out, I can say that the crossfader adjustment knob doesn't change the MIDI signals, so the crossfader curve adjustment is completely up the Mixxx.

Okay, thanks for checking.

Be-ing · 2017-04-14T05:14:18Z

+
+PioneerDDJSX.needleSearchTouched = false;
+
+PioneerDDJSX.needleSearchTouch = function(channel, control, value, status, group) {


When does this get executed? When touching the needle search? If so, I'm a bit confused about the purpose of the signal. Or is there a button to hold down while using the touch strip to prevent accidents?

Yes, this gets executed if you touch the needle strip, so the control of the needle strip is separated in that needleSearchTouch and needleSearchStripPosition. It's the same implementation/structure as for the jogwheel controls.

Hmm, okay. It may be helpful to add an option to require shift (or maybe the jog wheel?) to be pressed for needle searching to prevent accidents.

I will implement an option for requiring shift to do needle search!

Yeah, I could imagine someone accidentally hitting the touch strip while using the effects. That wouldn't be fun.

Be-ing · 2017-04-14T05:18:28Z

+
+PioneerDDJSX.playFromCuePoint = false;
+
+PioneerDDJSX.playIllumination = function(value, group, control) {


I'm confused what this is doing. Have you tested it with different cue modes set in Mixxx's preferences?

I will check this in different cue modes. The illumination control (LEDs inside the jogwheels) was not so easy to handle / to show me what I want to see.

After checking the different cue modes set in the Mixxx's preferences, I can say that there's no problem concerning the illumination control/ jog wheel LEDs. The illumination control is independent of the cue mode. A better way would be to be able to control the jog wheel LEDs itself, but as already said that would take a lot of rework (without using "Serato Mode").

Be-ing · 2017-04-14T05:27:22Z

+
+///////////////////////////////////////////////////////////////
+//                          JOGWHEELS                        //
+///////////////////////////////////////////////////////////////


I don't see anything here for the spinning LED display in the jog wheel. Have you gotten that working? You can look at the Reloop Beatmix 2/4 mapping for an example.

It is not possible to let the LEDs inside the jog wheel (illumination control) rotate backwards, there's no midi function for that (as far as I have seen). You can't control the LEDs separately on this controller and that's the main problem to show the correct turning/cue-position on this controller.

I see in Pioneer's demo video that the LEDs can rotate backwards with Serato. Another video shows it working with Traktor. So it is possible, but Pioneer has not documented it. You will probably have to intercept the MIDI messages Serato sends to the controller with MIDI OX (Windows) or MIDI Monitor (Mac) to figure out what to send. You might have to turn off the setting to use the controller with DJ software other than Serato.

It IS possible, but then I have to rework a lot of code, since not only the LEDs act differently in "Serato Mode". All PAD functionalities have to be controlled/interpreted differently and the MIDI messages are not documented. The mode "DJ Software other than Serato" makes it a lot more easier to handle in a first step. I want to rework the mapping concerning the jog LEDs, "Serato Mode" and PAD functionalities in the future, would that be ok? I don't know how fast I can "explore" all the necessary MIDI messages and how much time it costs to rework the pad functionalities.

Hmmm, okay. How are the pad signals different? Does it only send one signal for each pad no matter which pad mode is selected?

You might not need to redo the mapping. It is possible that sending the same MIDI signals for the jog LEDs that Serato sends still works in the non-Serato mode.

You can't switch the PAD MODE in "Serato Mode" and also the pads in the default CUE PAD MODE don't work. Another thing I saw is that the vu meters act differently in "Serato Mode". I have to monitor the MIDI signals to see what happens there instead.
I will test sending MIDI signals for the jog LEDs in non-Serato mode.
I also found some code controlling the jog LEDs and sending serato-messages to the controller, I have to figure that out. It would be nice, if the LEDs act as I want them to.

As a result of sending MIDI signals for the jog LEDs in non-serato mode, I can say that these LEDs won't light up :(. They only light up in serato-mode...so I have to figure a few MIDI signals out and do a little rework to the script and XML (to get PADs working in serato-mode).

Dang, that's annoying.

Be-ing · 2017-04-14T05:44:18Z

On the wiki you mention that the crossfader assignment switches are not mapped. Do they send MIDI signals? If so, they should be mapped. Mixxx's crossfader assignment switches are not shown in any skin presently for the main decks (they are for the samplers). That will be fixed with #940.

DJMaxergy · 2017-04-14T10:29:15Z

On the wiki you mention that the crossfader assignment switches are not mapped. Do they send MIDI signals?

Yes, they send MIDI signals and I can map them, but I don't know how as I can't see a ControlObject on the wiki for that. How can I assign the crossfader?

Be-ing · 2017-04-14T11:53:54Z

Yes, they send MIDI signals and I can map them, but I don't know how as I can't see a ControlObject on the wiki for that. How can I assign the crossfader?

The ControlObject is called "orientation".

Be-ing · 2017-04-14T12:28:38Z

+        'loadedDeck': 0x00, //deck 1-4: 0x00 - 0x03
+        'playPauseDeck': 0x0C, //deck 1-4: 0x0C - 0x0F
+        'cueDeck': 0x10, //deck 1-4: 0x10 - 0x13
+        'djAppConnect': 0x09


What does sending this MIDI message do? It does not look like you send it anywhere in the script. I am guessing that it asks the controller to send the positions of all the knobs and faders so their initial positions can be set in the software on startup. If so, you'll have to delay enabling soft takeover until after the first MIDI messages are received (the Components library does that automatically).

This MIDI message is just listed here as it exists / is available. I tried it but could not see any reaction, so I don't send it in the script. It also doesn't ask the controller to send positions of knobs and faders to the software. Nothing happens sending it. I think I remove it from here.

Hmm, maybe it does that in Serato mode? Controllers designed for Serato typically have a message that Serato sends them on startup to sync the software to the positions of the knobs and faders. When you're looking at the messages for the jog wheel LEDs, look for that message when Serato starts.

DJMaxergy · 2017-04-14T14:46:53Z

The ControlObject is called "orientation".

Thank you and SORRY that I didn't see this on the wiki!! I implement the crossfader assignment!

Be-ing · 2017-04-14T14:50:52Z

Thank you and SORRY that I didn't see this on the wiki!! I implement the crossfader assignment!

No problem, it is not well named. I edited the description on the wiki so it should be easier to find if someone does a text search for "crossfader assign" in their browser.

DJMaxergy · 2017-04-14T15:38:58Z

I see this controller uses 14 bit MIDI for the effects knobs. I'll add support for this in #1227 and #1211, but I don't have any controllers that use 14 bit MIDI myself, so I'd need someone else to test if it actually works.

I will help you with that as soon as I've done all other "ToDos" for the controller mapping.

DJMaxergy · 2017-04-15T14:18:18Z

By the way: As far as I have seen, the mapping will work for the DDJ-SX2, too (except the colored PAD lights).

Be-ing · 2017-04-15T19:08:30Z

By the way: As far as I have seen, the mapping will work for the DDJ-SX2, too (except the colored PAD lights).

Nice. Hopefully someone will adapt this for the DDJ-SX2 after this is finished.

…nted Sysex handshake and controls’ status (fader position etc.) to update Mixxx controls on init, Added user option to use SHIFT for controlling needle search, Optimizations concerning softTakeover, Implemented Slicer-functionalities and moved beatloops to group2, Optimizations concerning sampler velocity mode. Pioneer DDJ-SX.midi.xml: Sorted XML tags into a logical order

DJMaxergy · 2017-05-06T14:14:54Z

I'm back with a lot of changes....I reworked the wheel LEDs to react to play position, implemented a Sysex handshake and now all control positions are set according the actual positions on the controller during the init function AND implemented slicer functionalities. I have to update the wiki now.

sblaisot · 2017-05-06T14:53:13Z

+
+    // send init message to controller:
+    midi.sendSysexMsg(PioneerDDJSX.initSendMsg, PioneerDDJSX.initSendMsg.length);
+    PioneerDDJSX.initTimer = engine.beginTimer(1000, "PioneerDDJSX.initTimerTick()");


Why not just use 5000 as timer length and remove the increment/if >5 from initTimerTick() ?

Sometimes you don't see the easier way... I will change that.

Why is this necessary? Does the controller ever fail to send back the sysex message to complete the handshake?

What I realized is that when I start Mixxx, the handshake (send syses message to controller and controller sends syses message back) works safe/reliable, but when I update the *.js file when Mixxx has already started, the handshake works only sometimes and it seems that the controller doesn't send back anything, but I don't know why. That's why I integrated this timer thing. What is the difference between the init during Mixxx startup and the init when js-file is being updated when Mixxx has already started??

That's strange. As far as I know the only difference is that updating the JS file executes the shutdown function before calling init again.

Ok, I will do another test later. Serato doesn't send anything to the controller on shutdown. So I will comment out everything what happens in the shutdown function and do a few tests starting/closing Mixxx and updating *.js-File when Mixxx has already started. But I don't think that will change anything as I only send usual messages (like during playback for example) to the controller on shutdown. I only reset the LEDs.

I found out now or I think that it's a timing issue between the shutdown and the init, that updating js-file causes the controller not to respond to the syses message. There are a lot of midi messages in the shutdown to reset all LEDs. Serato doesn't reset anything at all on shutdown. So....should I simplify the script by deleting the timer and the LED resets inside the shutdown function (to what I tend to at the moment) or should I leave it?

As I deleted the handshake, the shutdown function is no problem now. The LEDs will be reset during shutdown and on updating the js-file the MIDI message to get the controls status works.

sblaisot · 2017-05-06T14:55:45Z

+    0x05, 0x09, 0x0F, 0x0F, 0x01, 0x08, 0x00, 0x09, 0xF7
+];
+PioneerDDJSX.initRecvMsg = [
+    0xF0, 0x00, 0x20, 0x7F, 0x01, 0x02, 0x01, 0x02, 0x12,


Are you sure this message is independent of firmware revision or controller serial number ?

It's independent of the serial number, because I tested two different controllers of the same type. Firmware version....I'm not really sure, I just saw that every hex value after the first 7 changes every time serato starts, so I think it has something to do with timestamp and checksum.

Humm, these are Serato Sysex Messages (00 20 7F is Serato identifier), so it should only work with DDJ-SX in Serato Mode.
I think DDJ-SX can be switched to other modes, so probably in these other modes, I will not work with these serato sysex messages.

Maybe at least document on the wiki that this mapping is only designed for DDJ-SX in Serato mode.

Yes, this was my intention...the controller must be in serato mode now (because of the wheel LEDs and PADs! I already wrote that I have to update the wiki. I will do that tomorrow.

I'm glad you got it working in Serato mode so users don't have to go through the setup process.

There came something to my mind concerning the handshake and the midi message to get the controller pot/knob states: I tested the init without the Serato sysex message and found out that it doesn't make any difference if I send this and receive this message or not. So the handshake during the init is just a verification that the correct controller is connected and not really necessary. Should I keep this handshake thing or should I delete it to simplify the script?

Be-ing

The changes mostly look good. I'm glad you got the jog wheel LEDs and initializing the potentiometer positions to work. I'll take a closer look at the slicer code after you update the wiki.

The updates for the EffectUnit object in the Components library have been merged. This will make it easy to map the effects sections to take full advantage of the new effects UI once you merge the latest updates from master into this branch. Documentation is on the wiki. If you have any questions about using the library, feel free to ask. Refer to the Pot documentation for how to map both the MSB and LSB messages for the effects knobs. The example code in the EffectUnit documentation defines midi attributes for the knobs, but that is not strictly necessary because they don't send MIDI output and the input signals are handled by the XML. After implementing a way to register MIDI input handlers from JS, the midi attributes for Pot Components will be needed, but that won't happen for Mixxx 2.1.

Be-ing · 2017-05-06T15:07:56Z

 PioneerDDJSX.useNewLibraryControls = false; //default: false

+// If true, SHIFT has to be pressed to activate needle search control
+PioneerDDJSX.needleSearchShiftEnable = false; //default: false


The default is right there, so there's no need to repeat it in a comment.

Ok I delete the default comments.

Or you could move them to the line above in case someone forgot what the default was after changing it and wants to change it back.

That's a good idea!

Be-ing · 2017-05-06T15:20:18Z

-    trackLoaded = engine.getValue(group, "track_loaded");
-    if (!trackLoaded) {
-        return;
+    if (value >= 0) {


playposition can go below 0 when seeking before the beginning of the track.

I read that but it doesn't make any sense to me to let the wheel LEDs rotate when seeking before the beginning of the track. Not good?

Yes, it does make sense. If you look at the waveform on screen it shows a position before the track, so the jog wheel should match that.

Ok I will change and test it!

Be-ing · 2017-05-06T15:43:49Z

+
+    // send init message to controller:
+    midi.sendSysexMsg(PioneerDDJSX.initSendMsg, PioneerDDJSX.initSendMsg.length);
+    PioneerDDJSX.initTimer = engine.beginTimer(1000, "PioneerDDJSX.initTimerTick()");


Why is this necessary? Does the controller ever fail to send back the sysex message to complete the handshake?

Be-ing · 2017-05-06T15:50:02Z

-    engine.connectControl("[Channel4]", "VuMeter", "PioneerDDJSX.VuMeterLeds", !bind);
 };

 PioneerDDJSX.setDeckSoftTakeover = function(channel, enable) {


It looks like this is only executed if the initialization handshake fails. Is that correct?

Yes, this is correct. But I think I'm going to remove the handshake and the setDeckSoftTakeover, too (because the pot/knob states are initialized by the controller and have to be set by the controller).

Be-ing · 2017-05-06T15:53:20Z

+PioneerDDJSX.initAfterHandshake = function(status) {
+    // initiate control status request:
+    if (status) {
+        midi.sendShortMsg(0x9B, 0x08, 0x7F);


Please add a comment somewhere explaining the initialization process. If I understand correctly, it goes like:

Software sends initial sysex message

Controller sends a different sysex message back

Software sends this normal MIDI message

Controller sends positions of all knobs and faders

Other Pioneer controllers probably follow the same process, so it would be helpful to have this documented.

Is it necessary to send the sysex message? Could you just send 0x9B, 0x08, 0x7F?

Did you ever figure out what the "DJ App Connect" MIDI message does (if anything)? I edited the DDJ-SB2 mapping to send that in the init function in #1243 but I didn't get a chance to test what it actually does.

I found out that sending the sysex message isn't necessary. Important is just to send 0x9B, 0x08, 0x7F. I also tried sending this "DJ App Connect" MIDI message, but it doesn't seem to do anything. I have no idea for what it is for. I logged every message Serato sends but this message does never appear.

Okay, thanks for testing. I'll update the DDJ-SB2 mapping in #1243 to send that same message. Hopefully it works for that controller too, but I no longer have access to a DDJ-SB2 to test.

A friend of mine has this controller. When there's time, I could test it with him.

Cool, thanks!

Be-ing · 2017-05-06T16:43:52Z

@@ -1776,20 +2008,21 @@ PioneerDDJSX.hotCueLeds = function(value, group, control) {

 PioneerDDJSX.VuMeterLeds = function(value, group, control) {


I don't see any function connected to [Master], VuMeter. Are the master meters controlled by the hardware in response to the sound card output?

Yes, the "Master" vu meters are controlled by the hardware.

Okay, please add a comment in the code making note of that.

Be-ing · 2017-05-06T16:45:22Z

+        value = 0x76;
    }

    if (engine.getValue(group, "PeakIndicator")) {


Does this make it so the red LEDs only light up when the deck is clipping? That is how it should be.

Yes, exactly. This is an effect I realized when switching from "DJ software other than Serato"-mode to "Serato"-mode.

Okay, good. I added a new guideline to the Contributing Mappings wiki page to clarify this because when I tested the Pioneer DDJ-SB2 mapping recently I discovered the scaling of the controller's level meters did not match Mixxx, which defeated the purpose of having level meters on the controller.

Be-ing · 2017-05-06T16:50:11Z

+PioneerDDJSX.toggledBrake = [false, false, false, false];
+PioneerDDJSX.scratchMode = [true, true, true, true];
+PioneerDDJSX.wheelLedsBlinkStatus = [0, 0, 0, 0];
+PioneerDDJSX.padMode = [0, 0, 0, 0]; //0 = HOTCUE, 1 = ROLL, 2 = SLICER, 3 = SAMPLER


Make an object to name each of these modes like an enum in C or C++ so there are not magic numbers in the code:

PioneerDDJSX.padModes = { hotcue: 0, roll: 1, slicer: 2, sampler: 3, } PioneerDDJSX.activePadMode = [PioneerDDJSX.padModes.hotcue, PioneerDDJSX.padModes.hotcue, PioneerDDJSX.padModes.hotcue, PioneerDDJSX.padModes.hotcue];

You're right. I will change that.

Be-ing · 2017-05-06T16:54:41Z

+        startPos = 0,
+        beatsToJump = 0;
+
+    if (PioneerDDJSX.slicerType[deck] === 1) {


Use an object to name the possible values for slicerType so there are not magic numbers in the code.

Will be done!

Be-ing · 2017-05-06T16:58:38Z

+        }
+        if (startPos >= Math.abs(beatsToJump) && PioneerDDJSX.slicerPreviousBeatsPassed[deck] !== PioneerDDJSX.slicerBeatsPassed[deck]) {
+            PioneerDDJSX.slicerPreviousBeatsPassed[deck] = PioneerDDJSX.slicerBeatsPassed[deck];
+            if (Math.abs(beatsToJump) > 0) {


Why can't this jump backwards?

Whoops, I glanced over the Math.abs. But this check is not necessary because setting the beatjump Control to 0 does not do anything.

I was not sure about what happens if I call beatjump with 0. Then I can remove the if-clause here.

Actually, keep it. #1187 will change the beatjump Control so it updates beatjump_size, and setting it to 0 would make the beatjump_size spinbox show 1/32.

Be-ing · 2017-05-06T19:10:24Z

It is easier to review and keep track of changes if you make a smaller Git commit for each change. If you have already made unrelated changes without making a new commit, a GUI Git client is helpful to select only specific changes for each commit. We have a list of some GUI Git clients on the wiki. Personally I prefer Git Cola.

Be-ing · 2017-05-06T19:21:13Z

-    if (!trackLoaded) {
-        return;
+    if (value >= 0) {
+        wheelPos = 0x01 + ((speed * (value * duration)) % 0x48);


speed and 0x48 look like magic numbers. Is there any math behind these numbers, or did you just guess and check until it looked like it worked right?

For the clarity of the code, it would be helpful to have an intermediate variable for value * direction called something like playPositionInSeconds.

Refer to the Reloop Beatmix 2/4 mapping code for an example of how to make the code clearer.

The Reloop Beatmix 2/4 mapping calculates the position of the jog LED so it rotates at 33 1/3 RPM like a turntable, which is also how the jog scratching is set up.

speed and 0x48 are no magic numbers. speed represents the turntable rotation (33 1/3 RPM), it is calculated on paper before. I will change the code so you will see the calculation according scratch RPM parameter. 0x48 is the maximum hex value/midi message value representing all LEDs are on (one complete wheel turn). I will add intermediate variables to make the calculation visible and the code clearer.

DJMaxergy · 2017-05-20T20:09:59Z

Just edit the midi-components-0.0.js file and commit that change by itself, then make separate commits for your edits to Pioneer-DDJ-SX-scripts.js. You don't need to make another branch.

Ok, as my branch is 363 commits behind the master branch and the midi-components-0.0.js file is in an very old state, what is the right way to update this file in my controller branch so it has the same state as the master? After that I could make the change I think.

…o. I didn’t see this.

Be-ing · 2017-05-20T21:35:29Z

Almost done! Now that the effects controls can be toggled between units 1/3 and 2/4 it would be good to have a way to assign decks to units 3 & 4. The most obvious way would be shift + effect unit routing buttons at the top of the mixer columns. However, it would be distracting to see those LEDs flash every time the shift button is pressed for an unrelated reason. How about repurposing the Panel Select button to act as a shift button for the effect unit assignment buttons?

The version of the Deere skin currently in the master branch can't show effect units 3 & 4 (that will be changed with #940), but the new Tango skin does.

With the CueButton object in Components, I made shift + cue jump to the beginning of the track and stop (using the start_stop ControlObject). The brake effect is cool, but I think this would be a better use of shift + cue. (You don't need to use the CueButton in Components for this; that would require more refactoring than necessary.) I think braking should be an effect, but it was made before the effects system was implemented. I just opened a bug report for this.

Be-ing · 2017-05-20T21:49:47Z

Ok, as my branch is 363 commits behind the master branch and the midi-components-0.0.js file is in an very old state, what is the right way to update this file in my controller branch so it has the same state as the master? After that I could make the change I think.

Merge the master branch first:

$ git remote add upstream https://github.com/mixxxdj/mixxx.git
$ git fetch upstream
$ git merge upstream/master

DJMaxergy · 2017-05-21T15:16:01Z

Merge the master branch first

Ok, I did that already. What's next? How do I get the components file from the master to the mapping branch? Or can I change it in my forked master branch?

Be-ing · 2017-05-21T15:21:03Z

How do I get the components file from the master to the mapping branch?

Merging the master branch into your mapping branch does this. Then edit the file on your mapping branch and commit it.

DJMaxergy · 2017-05-21T15:30:27Z

How about repurposing the Panel Select button to act as a shift button for the effect unit assignment buttons?

I don't know....I think that this solution would not be very intuitive and the Panel Select button already has another functionality. I would rather take the obvious solution using shift. Would that be ok, too? I don't see any better way at the moment.

The brake effect is cool, but I think this would be a better use of shift + cue.

Hm...I like the brake effect and I want to use it but I don't know where else to put it at the moment. I understand you and I think it should be an effect, too (like in VirtualDJ I think). So if I replace the SHIFT+CUE functionality now I cannot use the brake effect any more. But it would be better if SHIFT+CUE leads to the beginning of the track.

…usChooseMode in the definition of the effectFocusButton to use this.on and this.off values (in order to guarantee that the controller button led will light up).

DJMaxergy · 2017-05-21T15:42:31Z

The brake effect is cool, but I think this would be a better use of shift + cue.

Ah sorry, there's a mistake in the wiki. I correct that. SHIFT+CUE toggles spinback effect at the moment, not brake. But it's the same problem....I think I change SHIFT+CUE to jump to the beginning of the track.

…the beginning of the track and stop.

Be-ing · 2017-05-22T01:32:37Z

I don't know....I think that this solution would not be very intuitive and the Panel Select button already has another functionality. I would rather take the obvious solution using shift. Would that be ok, too?

I think you'd find it quite distracting to see the lights on the effect unit routing buttons switch when you press shift to access a shifted functionality on the decks.

I don't see any better way at the moment.

How about moving the current Panel button functionality to shift + Panel and using Panel without shift for the effect unit 3 & 4 assignment layer?

Be-ing · 2017-05-22T01:33:21Z

                };
                this.output = function (value, group, control) {
-                    this.send(value === this.number);
+                    this.send((value === this.number) ? this.on : this.off);


Thanks for figuring this out!

Be-ing · 2017-05-26T01:00:36Z

Now that #1187 has been merged, update this to make use of the new Controls. How about:
AUTO LOOP: beatloop_activate
AUTO LOOP + shift: beatlooproll_activate
1/2x: keep as loop_halve
1/2x + shift: beatjump_1_backward (will move loop if a loop is enabled)
2x: keep as loop_double
2x + shift: beatjump_1_forward
IN: keep as loop_in
IN + shift: reloop_andstop
OUT: keep as loop_out
Out + shift: reloop_toggle
From the wiki, it looks like parameter left/right in HOTCUE mode is unused. How about mapping it to beatjump_backward/forward, and with shift, halve/double beatjump_size.

… EffectUnit 3 and 4 by pressing SHIFT + PANEL SELECT. Also button LEDs will light up according EffectUnit assignment (to see assignment of EffectUnit 3 and 4 SHIFT + PANEL SELECT must be pressed).

… CUE Mode parameter buttons to jump beats according beatjump_size and shift + parameter buttons to change the beatloop_size. Fixed Led reset function concerning fx button leds as EffectUnits 3 and 4 were added in the previous commit.

Be-ing · 2017-06-02T05:15:23Z

The updates to the Deere skin in #940 that make use of the new loop controls were merged to master, so you can now use the latest master build to update the mapping.

…4 assignment only when SHIFT and PANEL SELECT is pressed.

DJMaxergy · 2017-06-06T20:26:42Z

@Be-ing : Sorry that it was so silent here in the last weeks but now I found time to implement nearly everything you suggested. I left the panel select functionality as it is and added the EffectUnit 3 and 4 assignment to SHIFT + PANEL SELECT + FX1/2. Concerning the loop functionalities I left the SHIFT + AUTO LOOP function as it is (activate current loop) and didn't replace it by beatlooproll_activate as this would confuse users (perhaps) because it doesn't match the labeling of the button.

Be-ing

Thanks for the updates. By the way, if you did not notice, you can now hold loop_in/out while a loop is active and move the jog wheel to adjust the loop in/out point.

Be-ing · 2017-06-06T21:06:06Z

-        engine.setValue(group, "beatloop_" + PioneerDDJSX.selectedSlicerQuantization[deck] + "_activate", value);
        engine.setValue(group, "slip_enabled", value);
+        engine.setValue(group, "beatloop_size", PioneerDDJSX.selectedSlicerQuantization[deck]);
+        engine.setValue(group, "beatloop_activate", value);


This change wasn't necessary because beatloop_X_activate changes beatloop_size to X, but there's no need to change it back.

Be-ing · 2017-06-06T21:17:41Z

+            engine.setValue(group, "reloop_toggle", true);
        } else {
-            engine.setValue(group, "beatloop_" + 4 + "_toggle", true);
+            engine.setValue(group, "beatloop_activate", true);


beatloop_activate should be reset to 0 on button up or the button on screen will stay lit. reloop_toggle should also be reset to 0 (the button in skins lights up with loop_enabled, but just in case a skin doesn't do that, the controller script shouldn't leave reloop_toggle stuck at 1).

It's confusing that there are multiple buttons for reloop_toggle. However, it would also be redundant to use shift and this button for beatlooproll_activate because of the ROLL pad mode, so I'm not sure it matters much either way...?

Be-ing · 2017-06-06T21:22:52Z


 PioneerDDJSX.loopActiveButton = function(channel, control, value, status, group) {
-    script.toggleControl(group, "reloop_exit");
+    script.toggleControl(group, "reloop_toggle");


As I realized with #1271, toggling Controls on each button down/up event can cause strange situations if the Control does not start in the expected state. For example, if reloop_toggle happens to be 1 for whatever reason when the button is pressed, it will be set to 0 on button down and reset to 1 on button up, which will not produce the expected behavior. It's better to set the Control to 1 on button press and 0 on button release, regardless of the state of the Control before the button was pressed.

Be-ing · 2017-06-06T21:42:06Z


 PioneerDDJSX.shiftPanelSelectButton = function(channel, control, value, status, group) {
    var channelGroup;
+    PioneerDDJSX.shiftPanelSelectPressed = value ? true : false;


If I understand correctly, you need to hold shift, hold panel, and press an effect assignment button to toggle assignment for effect units 3 & 4? Don't you need 3 hands for that? This is why I suggested moving the old Panel functionality to shift + Panel, so you could hold the Panel button with one hand and press the effect unit assignment button with the other hand.

You understood that correctly, but it's very easy to hold shift and panel select with one hand. In either way you need two hands to assign EffectUnit 3 and 4. I can put my thumb onto the shift button and my forefinger onto the panel select easily while pressing the assignment buttons with the other hand. I have chosen this way because then the original panel select function can be maintained and I think it's more intuitive to activate/deactivate panels (samplers, effects) if you don't press shift (as the button is only labeled PANEL SELECT).

Okay, I don't have a DDJ-SX to try this with, so I'll take your word for it. I think this will be ready for merge after addressing the comments about the loop related buttons below.

DJMaxergy · 2017-06-10T08:48:20Z

By the way, if you did not notice, you can now hold loop_in/out while a loop is active and move the jog wheel to adjust the loop in/out point.

I have problems figuring this out: If I hold loop_in the loop in marker moves according the play position. So if I hold it long enough without touching the jog wheel, the loop length gets 0 and the loop in marker moves with the play position. Is that the desired behaviour?
I thought the loop length/position stays the same until I move the jog wheel.
When I touch the jog wheel during loop_in hold pressed, I'm just scratching as normally and the loop in marker moves with the play position.
What do I have to do differently?

@Be-ing: Can you give me a few details how this is intended to be used?

… not to use script.toggleControl but engine.setValue and reset parameter value on button release. Also changed button led behavior to react to loop_enabled.

Be-ing · 2017-06-13T16:44:33Z

+    if (engine.getValue(group, "loop_enabled")) {
+        engine.setValue(group, "reloop_toggle", value);
+    } else {
+        engine.setValue(group, "beatloop_activate", value);


This will not work as expected. Setting beatloop_activate to 1 sets loop_enabled to 1, so on button release this will set reloop_toggle to 0 instead of beatloop_activate, so the beatloop_activate button will stay lit on screen. Try this:

if (value) { if (engine.getValue(group, "loop_enabled")) { engine.setValue(group, "reloop_toggle", true); engine.setValue(group, "reloop_toggle", false); } else { engine.setValue(group, "beatloop_activate", true); engine.setValue(group, "beatloop_activate", false); } }

You're right, I didn't see that. But it's strange because it's working as it should. That's why I didn't see it. I will try your solution.

Both code parts are working, but yours is correct.
I also realized another "maybe bug" which has nothing to do with my controller mapping, as it doesn't work on the skin as well. If I load a track and do a beatloop it stays marked in the waveform at the next start of Mixxx. But at this next start I could't do the reloop_toggle. I have to make a new beat loop to be able to use reloop_toggle. I could load other tracks and reload that track with the beat loop again and the reloop_toggle is working. But on the next start of Mixxx it isn't working anymore on this track with this previously created beat loop until I make a new beat loop. Before reloop_toggle I used reloop_exit and it worked in that situation.

Ok, I just found out that I have to load a track twice to get the reloop_toggle working on a track with a previously created beat loop but that's strange I think.

The issue with storing loops is a known bug.

Ah ok, thank you for the explanations!

…vate correctly.

Be-ing · 2017-06-13T19:06:24Z

I have problems figuring this out: If I hold loop_in the loop in marker moves according the play position. So if I hold it long enough without touching the jog wheel, the loop length gets 0 and the loop in marker moves with the play position. Is that the desired behaviour?
I thought the loop length/position stays the same until I move the jog wheel.
When I touch the jog wheel during loop_in hold pressed, I'm just scratching as normally and the loop in marker moves with the play position.
What do I have to do differently?

That is working as intended. Holding the button down moves the loop in/out marker as the playhead moves. So holding the button while moving the jog wheel moves the marker, as well as holding the button while the track is playing.

Be-ing · 2017-06-13T19:27:31Z

Yay! LGTM! Thank you for contributing the first complete Mixxx mapping for a popular high end controller. :) I'm sure many people will be grateful for this. I hope I get a chance to play with it sometime. @daschuer, could you merge this?

DJMaxergy · 2017-06-14T22:05:38Z

Yeah! Thank you very much for your support @Be-ing ! After this mapping is merged I hope I can get m y hands on the SX2 sometime and do a mapping for this controller, too (nearly everything can be adapted from SX mapping).

Be-ing · 2017-06-22T07:19:05Z

ping @daschuer: ready for merge?

daschuer · 2017-06-22T16:06:25Z

Thank you for all the work!

DJMaxergy added 2 commits April 2, 2017 19:28

First creation of controller mapping for Pioneer DDJ-SX

c09a5e1

Merge branch 'master' of https://github.com/DJMaxergy/mixxx into pion…

13657be

…eerDDJSX_mapping

Updated windows uninstaller

96413f0

radusuciu reviewed Apr 10, 2017

View reviewed changes

Be-ing reviewed Apr 11, 2017

View reviewed changes

radusuciu reviewed Apr 12, 2017

View reviewed changes

Be-ing mentioned this pull request Apr 13, 2017

Components EffectUnit rework #1211

Merged

2 tasks

Be-ing suggested changes Apr 14, 2017

View reviewed changes

Be-ing reviewed Apr 14, 2017

View reviewed changes

sblaisot reviewed May 6, 2017

View reviewed changes

Be-ing suggested changes May 6, 2017

View reviewed changes

Be-ing reviewed May 6, 2017

View reviewed changes

Sorry, I had to fix the function calls for the second effect unit, to…

c73dfc5

…o. I didn’t see this.

DJMaxergy added 2 commits May 21, 2017 17:31

Merge branch 'master' into pioneerDDJSX_mapping

08dcc1f

midi-components-0.0.js: Changed the output function in startEffectFoc…

fb79a04

…usChooseMode in the definition of the effectFocusButton to use this.on and this.off values (in order to guarantee that the controller button led will light up).

Changed SHIFT+CUE functionality from spinback effect to jump back to …

0a3bfec

…the beginning of the track and stop.

Be-ing reviewed May 22, 2017

View reviewed changes

DJMaxergy added 2 commits May 31, 2017 18:56

Added FX ASSIGN BUTTON functionality to be able to assign Deck 1-4 to…

b189aba

… EffectUnit 3 and 4 by pressing SHIFT + PANEL SELECT. Also button LEDs will light up according EffectUnit assignment (to see assignment of EffectUnit 3 and 4 SHIFT + PANEL SELECT must be pressed).

Added shiftPanelSelectPressed variable for enabling EffectUnit 3 and …

53265fd

…4 assignment only when SHIFT and PANEL SELECT is pressed.

Be-ing suggested changes Jun 6, 2017

View reviewed changes

Replaced autoLoopButton, loopActiveButton and loopExitButton behavior…

38063b5

… not to use script.toggleControl but engine.setValue and reset parameter value on button release. Also changed button led behavior to react to loop_enabled.

Be-ing reviewed Jun 13, 2017

View reviewed changes

Corrected autoLoopButton function code to set and reset beatloop_acti…

f6737a0

…vate correctly.

daschuer merged commit 2f606bc into mixxxdj:master Jun 22, 2017


		PioneerDDJSX.blinkAutodjState = 0;

		PioneerDDJSX.vuMeterTwinkle = function() {


		PioneerDDJSX.needleSearchTouched = false;

		PioneerDDJSX.needleSearchTouch = function(channel, control, value, status, group) {


		PioneerDDJSX.playFromCuePoint = false;

		PioneerDDJSX.playIllumination = function(value, group, control) {

		@@ -1776,20 +2008,21 @@ PioneerDDJSX.hotCueLeds = function(value, group, control) {

		PioneerDDJSX.VuMeterLeds = function(value, group, control) {

Uh oh!

Conversation

DJMaxergy commented Apr 8, 2017

Uh oh!

sblaisot commented Apr 8, 2017

Uh oh!

Be-ing commented Apr 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Be-ing Apr 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DJMaxergy commented Apr 13, 2017

Uh oh!

Be-ing commented Apr 13, 2017

Uh oh!

Be-ing commented Apr 13, 2017

Uh oh!

Be-ing left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Be-ing Apr 11, 2017 •

edited

Loading

Be-ing left a comment •

edited

Loading

Be-ing Apr 14, 2017 •

edited

Loading