Skip to content

FindVorbis: Link ogg in static builds#12297

Merged
daschuer merged 1 commit into
mixxxdj:mainfrom
fwcd:linux-static-vorbis-ogg
Nov 13, 2023
Merged

FindVorbis: Link ogg in static builds#12297
daschuer merged 1 commit into
mixxxdj:mainfrom
fwcd:linux-static-vorbis-ogg

Conversation

@fwcd
Copy link
Copy Markdown
Member

@fwcd fwcd commented Nov 12, 2023

We have to link libogg into libvorbis when building static binaries on Linux, see e.g. this build:

/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux/lib/libvorbis.a(block.c.o): in function `vorbis_block_init':
block.c:(.text+0x3f8): undefined reference to `oggpack_writeinit'
/usr/bin/ld: block.c:(.text+0x415): undefined reference to `oggpack_writeinit'
/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux/lib/libvorbis.a(block.c.o): in function `vorbis_block_clear':
block.c:(.text+0x58a): undefined reference to `oggpack_writeclear'
/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux/lib/libvorbis.a(analysis.c.o): in function `vorbis_analysis':
analysis.c:(.text+0x48): undefined reference to `oggpack_reset'
...

@fwcd fwcd force-pushed the linux-static-vorbis-ogg branch from 41c364c to a2a4782 Compare November 12, 2023 22:01
@fwcd fwcd marked this pull request as ready for review November 12, 2023 22:15
@fwcd
Copy link
Copy Markdown
Member Author

fwcd commented Nov 12, 2023

Seems to work, there are no more oggpack_* linker errors in this build.

Copy link
Copy Markdown
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer daschuer merged commit 18e17c2 into mixxxdj:main Nov 13, 2023
@fwcd fwcd deleted the linux-static-vorbis-ogg branch November 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants