FindSleef: Use OpenMP in static builds#12295
Merged
daschuer merged 3 commits intomixxxdj:mainfrom Nov 13, 2023
Merged
Conversation
2 tasks
b369e77 to
47c06dc
Compare
Member
Author
|
Looks like we may have to do this for |
Member
Author
|
Related issue in upstream vcpkg: microsoft/vcpkg#32744 |
8a6fdce to
941c765
Compare
fwcd
commented
Nov 12, 2023
| set_property(TARGET rubberband::rubberband APPEND PROPERTY INTERFACE_LINK_LIBRARIES | ||
| Sleef::sleef | ||
| ${sleefdft_path} | ||
| Sleef::sleefdft |
Member
Author
There was a problem hiding this comment.
Cleaning up this logic also has the side effect of making this dependency slightly more elegant.
97072e7 to
4b4ce35
Compare
Member
Author
|
The build went through, so I will mark this one as ready for review too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking the vcpkg-built sleef statically on Linux seems to require OpenMP (see e.g. this build):