FindLibudev: Link hidapi and libusb with libudev in static builds on Linux#12294
Merged
daschuer merged 3 commits intomixxxdj:mainfrom Nov 13, 2023
Merged
FindLibudev: Link hidapi and libusb with libudev in static builds on Linux#12294daschuer merged 3 commits intomixxxdj:mainfrom
daschuer merged 3 commits intomixxxdj:mainfrom
Conversation
2 tasks
Member
Author
|
Hm, maybe we should add a new |
82b0fb3 to
573c269
Compare
573c269 to
7b032e0
Compare
7b032e0 to
acac65e
Compare
Member
Author
|
I've named the module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the other static linking PRs (#12291, #12292), some of the hidapi-related dependencies have a dependency on
libudevthat we'll have to link in explicitly in static builds (see e.g. this build):Click to see full linker error
Note that
libudevitself will likely still have to be linked dynamically, since it is part of the systemd libraries.