Skip to content

draw background color of WOverview#1208

Merged
daschuer merged 2 commits intomixxxdj:masterfrom
Be-ing:overview_background_color
Mar 7, 2017
Merged

draw background color of WOverview#1208
daschuer merged 2 commits intomixxxdj:masterfrom
Be-ing:overview_background_color

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Mar 6, 2017

Previously setting the BgColor element of an Overview element in the skin XML did nothing.

@Be-ing Be-ing mentioned this pull request Mar 6, 2017
12 tasks
@daschuer
Copy link
Copy Markdown
Member

daschuer commented Mar 6, 2017

I think we can than remove the not working:

    QPalette palette; //Qt4 update according to http://doc.trolltech.com/4.4/qwidget-qt3.html#setBackgroundColor (this could probably be cleaner maybe?)
    palette.setColor(this->backgroundRole(), m_qColorBackground);
    setPalette(palette);

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Mar 7, 2017

Thank you, LGTM.

@daschuer daschuer merged commit ea7356b into mixxxdj:master Mar 7, 2017
@Be-ing Be-ing deleted the overview_background_color branch April 25, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants