fix script connection object trigger method#1201
Merged
rryan merged 3 commits intomixxxdj:masterfrom Mar 1, 2017
Merged
Conversation
instead of all callbacks registered for a given ControlObject
rryan
reviewed
Mar 1, 2017
| } | ||
|
|
||
| coScript->emitValueChanged(); | ||
| QScriptValueList args; |
Member
There was a problem hiding this comment.
To reduce duplication -- want to make this a helper function on ControllerEngineConnection and call it from here and ControlObjectScript?
Contributor
Author
There was a problem hiding this comment.
I think there's quite a bit of work to do on these classes and I don't really want to go down that rabbit hole for 2.1. I don't understand why ControllerEngineConnection is even a class. It seems like it should be a struct of ControllerEngineConnectionScriptValue.
Member
There was a problem hiding this comment.
Yea it could just as easily be a struct.
It should be a tiny change -- I don't want to leave an opportunity for someone to change one place but not the other.
Member
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up from #1198