fix deletion of effect chain presets created in current session#11886
Conversation
|
This can be merged as is, though I need to figure what's wrong with the focus behaviour / event processing in that dialog. Can anyone else reproduce this (I'm using Qt 5.12.8 on Ubuntu 20.04):
|
4ee57c3 to
d8b14bb
Compare
|
Done, ready for review.
I changed the |
| m_pFocusedChainList->selectionModel()->selectedRows(0).count() > 1) { | ||
| auto* pSelModel = m_pFocusedChainList->selectionModel(); | ||
| auto selIndices = pSelModel->selectedIndexes(); | ||
| if (!pSelModel->hasSelection() || selIndices.count() > 1) { |
There was a problem hiding this comment.
This should clear the info labels and return if (selIndices.count() != 1).
I pushed the simplified version. Thanks!
649f50a to
52d629d
Compare
|
There are merge conflicts now. |
|
Conflicts resolved. In case the new tr string is an issue I can remove 46f2f91 and open a separate PR against |
|
pa-ping.. |
daschuer
left a comment
There was a problem hiding this comment.
LGTM and still works! Thank you.
readOnlycorrectly (false) for chain presets just created via the preset menu, regression from Effects: allow clearing chains with empty '---' preset #10859clicking any of the preset action buttons (Rename, Delete, ..) does sometimes clear the selection in the list views above, i.e. the buttons won't do anything.
Looks like the events are processed in unpredictable order: sometimes the Delete button gets focus and the list focus as well as the selection is cleared, sometimes the selection is cleared after the Delete dialog is closed (aborted, so the selected item is still in the list and selection should not change