Fix decoding of the last MP3 frame#1183
Merged
daschuer merged 1 commit intomixxxdj:2.1from Feb 11, 2017
uklotzde:libmad_last_mp3_frame
Merged
Fix decoding of the last MP3 frame#1183daschuer merged 1 commit intomixxxdj:2.1from uklotzde:libmad_last_mp3_frame
daschuer merged 1 commit intomixxxdj:2.1from
uklotzde:libmad_last_mp3_frame
Conversation
Member
|
If this is for the next release, you need to target the 2.1 branch instead of Master. |
Member
|
It is correct, that we have a already a 2.1 branch, but both are currently still in sync. |
Member
|
Test passed! Well done, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another fix for the upcoming release.
The code of SoundSourceMp3 is still ugly, but I don't want to rewrite this once again, even if mpg123 is more popular than libmad nowadays.