Traktor Kontrol S2MK3: Use FX select buttons to set quick effect presets by olivier-mauras · Pull Request #11702 · mixxxdj/mixxx

olivier-mauras · 2023-07-01T19:12:12Z

Rework of #11104 on 2.4 branch

ronso0 · 2023-07-02T15:34:42Z

Thank you!
Did also take a look at the reviews of #11104 ?

echozio

I tested this out with the controller, and the 8 effect logic works intuitively, however pressing 1 sets the effect at index 0, which is no effect (not visible when reordering in the settings).
This change should fix that.

echozio · 2023-07-02T15:45:03Z

+    const activeFx = {};
+    // Detect which fx should be enabled
+    for (const group of targetGroups) {
+        activeFx[group] = engine.getValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset");


Suggested change

activeFx[group] = engine.getValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset");

activeFx[group] = engine.getValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset") - 1;

echozio · 2023-07-02T15:45:18Z

-    TraktorS2MK3.outputHandler(TraktorS2MK3.fxButtonState[fxNumber], field.group, "fxButton" + fxNumber);
+    // Now apply the new fx value
+    for (const group of targetGroups) {
+        engine.setValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset", fxToApply[group]);


Suggested change

engine.setValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset", fxToApply[group]);

engine.setValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset", fxToApply[group] + 1);

echozio · 2023-07-02T15:45:28Z

+
+    const activeFx = {};
+    for (const group of availableGroups) {
+        activeFx[group] = engine.getValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset");


Suggested change

activeFx[group] = engine.getValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset");

activeFx[group] = engine.getValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset") - 1;

Actually I didn't want to sort it out this way, because I believe there's probably a bug in the quick effects settings page.
in 2.4-beta - at least for me:

the list order is never saved upon Mixxx exit and needs to be changed after restart

List index does not start with the first effect in the list but with "---" - If you get to the effect settings, hit "Restore Defaults", then the first index becomes the first effect

I believe that working around this behavior in the mapping will thus break next time the effect list behavior is sorted out

the list order is never saved upon Mixxx exit and needs to be changed after restart

Can't confirm. The list is saved correctly to effects.xml when Mixxx exits. Are you sure Mixxx is shutting correctly?

List index does not start with the first effect in the list but with "---" - If you get to the effect settings, hit "Restore Defaults", then the first index becomes the first effect

I would imagine this is a bug in the restore logic ("---" is not re-added when restoring)?

Mmmmh I must have badly tested, you're right list is properly saved, but "---" disappear on "Restore Defaults" which would break the "workaround" mapping though.
Which way should we fix it first? :)

I'll take a look.

This was fixed by #11705

ronso0 · 2023-07-02T16:18:17Z

Yes, I added the empty preset in #10859 so the list is 1-based.
Some (all?) new effect controls are not documented , yet, see mixxxdj/manual#501

olivier-mauras · 2023-07-02T16:40:23Z

Ok so I tested @echozio fix and added a new commit.
Works like a charm, just don't expect the behavior to be correct right after reloading defaults :)

ronso0 · 2023-07-02T20:35:15Z

Fix for the missing empty preset / list offset is here #11705

ronso0 · 2023-07-03T07:33:28Z

If mappings are created/updated the respective manual PR is a prerequisite for merging.
https://manual.mixxx.org/2.3/en/hardware/controllers/native_instruments_traktor_kontrol_s2_mk3.html
@olivier-mauras are you familiar with the manual repo?

olivier-mauras · 2023-07-03T20:00:00Z

@ronso0 mixxxdj/manual#568

JoergAtGithub · 2023-12-10T07:48:35Z

+    // If no shift button was pressed fall back to target all decks.
+    if (targetGroups.length === 0) {
+        targetGroups = availableGroups;
+        noShift = true;
+    }


Wouldn't it make sense to check here that the effect knob is in zero position (or close to it)? Otherwise we could reassign the effect chain preset, while it's audible.

IMO this is up to the user to decide, and the learing curve should be pretty steep ;)
Related: #11198

I'm not sure how this works currently, but when I used the code from my old PR knobs would always reset when switching effect, whether that be to the center position or the zero position and the knob would only control it again when moved back to the initial point.

JoergAtGithub · 2023-12-10T12:12:46Z

@ronso0 Than I think we can merge this. But in mixxxdj/manual#568 you asked to have a final look, when the mapping PR is ready.

ronso0 · 2023-12-10T13:21:12Z

Indeed, I'll do so soonish.

JoergAtGithub · 2024-01-08T18:57:14Z

LGTM! Thank you!

daschuer · 2024-01-17T21:26:51Z

Hi @olivier-mauras thank you for your contribution.
It looks like we have missed to ask for your permission to distribute your code before merge. Can you catch that up, sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ and comment here when done? I will then put your name to the Mixxx 2.4 contributor list in the Mixxx about box.

github-actions Bot added the controller mappings label Jul 1, 2023

Traktor Kontrol S2MK3: Use FX select buttons to set quick effect presets

558877d

olivier-mauras force-pushed the update/traktor-s2-mk3-fx-buttons branch from 25b1bd6 to 558877d Compare July 1, 2023 19:17

olivier-mauras mentioned this pull request Jul 1, 2023

Traktor Kontrol S2MK3: Use FX select buttons to set quick effect presets #11104

Closed

olivier-mauras changed the base branch from main to 2.4 July 1, 2023 19:21

Olivier Mauras added 2 commits July 2, 2023 00:35

Traktor Kontrol S2MK3: Add second FX per button

8fd6470

Traktor Kontrol S2MK3: Fix code style with pre-commit patch

4d57b22

echozio suggested changes Jul 2, 2023

View reviewed changes

Olivier Mauras added 2 commits July 2, 2023 18:19

Traktor Kontrol S2MK3: Fix comment syntax

5902e7b

Traktor Kontrol S2MK3: Support '---' as first item of the list

e861a5d

echozio approved these changes Jul 2, 2023

View reviewed changes

olivier-mauras mentioned this pull request Jul 3, 2023

Traktor Kontrol S2MK3: Add documentation for PR#11702 mixxxdj/manual#568

Merged

JoergAtGithub added the needs review label Aug 13, 2023

JoergAtGithub reviewed Dec 10, 2023

View reviewed changes

JoergAtGithub merged commit 3bb94a6 into mixxxdj:2.4 Jan 8, 2024

JoergAtGithub added changelog This PR should be included in the changelog and removed needs review labels Jan 8, 2024

	activeFx[group] = engine.getValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset");
	activeFx[group] = engine.getValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset") - 1;

	engine.setValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset", fxToApply[group]);
	engine.setValue(`[QuickEffectRack1_${group}]`, "loaded_chain_preset", fxToApply[group] + 1);

Uh oh!

Conversation

olivier-mauras commented Jul 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 commented Jul 2, 2023

Uh oh!

echozio left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

echozio Jul 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

echozio Jul 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Jul 2, 2023

Uh oh!

olivier-mauras commented Jul 2, 2023

Uh oh!

ronso0 commented Jul 2, 2023

Uh oh!

ronso0 commented Jul 3, 2023

Uh oh!

olivier-mauras commented Jul 3, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoergAtGithub commented Dec 10, 2023

Uh oh!

ronso0 commented Dec 10, 2023

Uh oh!

JoergAtGithub commented Jan 8, 2024

Uh oh!

daschuer commented Jan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

olivier-mauras commented Jul 1, 2023 •

edited

Loading

echozio Jul 2, 2023 •

edited

Loading

echozio Jul 2, 2023 •

edited

Loading