Skip to content

hid-controller-api.d.ts: Adapted the description from hidcontroller.h for parameter useNonSkippingFIFO#11664

Merged
Swiftb0y merged 2 commits intomixxxdj:2.4from
JoergAtGithub:UpdateHidApiDeclarations
Jun 19, 2023
Merged

hid-controller-api.d.ts: Adapted the description from hidcontroller.h for parameter useNonSkippingFIFO#11664
Swiftb0y merged 2 commits intomixxxdj:2.4from
JoergAtGithub:UpdateHidApiDeclarations

Conversation

@JoergAtGithub
Copy link
Copy Markdown
Member

The formatting should be readable with editors that the support MarkDown in JSDoc and editors that print the text unformatted
Behavior of the parameter was changed in #11326

… useNonSkippingFIFO

The formatting should be readable with editors that the support MarkDown in JSDoc and editors that print the text unformatted
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Comment thread res/controllers/hid-controller-api.d.ts Outdated
Comment thread res/controllers/hid-controller-api.d.ts Outdated
@JoergAtGithub JoergAtGithub requested a review from Swiftb0y June 18, 2023 22:11
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@Swiftb0y Swiftb0y merged commit 29f9ec2 into mixxxdj:2.4 Jun 19, 2023
@JoergAtGithub JoergAtGithub deleted the UpdateHidApiDeclarations branch June 19, 2023 22:06
@daschuer daschuer added this to the 2.4.0 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants