Skip to content

fix echo effect reducing volume of input #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daschuer merged 2 commits into from
Apr 5, 2017
Merged

fix echo effect reducing volume of input #1166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c98c3
fix echo effect reducing volume of input
Be-ing Feb 3, 2017
2207277
Merge remote-tracking branch 'upstream/master' into fix_echo_volume
Be-ing Feb 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/effects/native/echoeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,21 +151,21 @@ void EchoEffect::processChannel(const ChannelHandle& handle, EchoGroupState* pGr
if (gs.ping_pong_left) {
// Left sample plus a fraction of the right sample, normalized
// by 1 + fraction.
pOutput[i] = (pInput[i] +
(gs.delay_buf[read_position] +
pOutput[i] = pInput[i] +
((gs.delay_buf[read_position] +
gs.delay_buf[read_position + 1] * pingpong_frac) /
(1 + pingpong_frac)) / 2.0;
// Right sample reduced by (1 - fraction)
pOutput[i + 1] = (pInput[i + 1] +
gs.delay_buf[read_position + 1] * (1 - pingpong_frac)) / 2.0;
pOutput[i + 1] = pInput[i + 1] +
(gs.delay_buf[read_position + 1] * (1 - pingpong_frac)) / 2.0;
} else {
// Left sample reduced by (1 - fraction)
pOutput[i] = (pInput[i] +
gs.delay_buf[read_position] * (1 - pingpong_frac)) / 2.0;
pOutput[i] = pInput[i] +
(gs.delay_buf[read_position] * (1 - pingpong_frac)) / 2.0;
// Right sample plus fraction of left sample, normalized by
// 1 + fraction
pOutput[i + 1] = (pInput[i + 1] +
(gs.delay_buf[read_position + 1] +
pOutput[i + 1] = pInput[i + 1] +
((gs.delay_buf[read_position + 1] +
gs.delay_buf[read_position] * pingpong_frac) /
(1 + pingpong_frac)) / 2.0;
}
Expand Down