Skip to content

Biquad EQ with full kill feature #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daschuer merged 10 commits into from
Feb 4, 2017
Merged

Biquad EQ with full kill feature #1164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1c4fe42
Added a new Biquad EQ with full kill feature.
daschuer Jan 31, 2017
3198e1e
use SampleBuffer
daschuer Feb 1, 2017
e8ae22f
Smooth the knob scale even more.
daschuer Feb 1, 2017
19aec76
Fix ramping in EngineFilterDelay
daschuer Feb 3, 2017
56bfce5
De-click lvMixIsolator when enabling and disabling
daschuer Feb 3, 2017
a144202
De-click biquad eq when enabing and disabling
daschuer Feb 3, 2017
ec8fe1f
Adopt de-clicking code for Biquad EQ
daschuer Feb 3, 2017
437d5e4
De-click zero biquad crossing
daschuer Feb 3, 2017
439e4ac
Make Biquad EQ/ISO default
daschuer Feb 3, 2017
54c5bba
Remove leftover DEBUG_ASSERT
daschuer Feb 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/depends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,7 @@ def sources(self, build):
"effects/native/bessel4lvmixeqeffect.cpp",
"effects/native/bessel8lvmixeqeffect.cpp",
"effects/native/threebandbiquadeqeffect.cpp",
"effects/native/biquadfullkilleqeffect.cpp",
"effects/native/loudnesscontoureffect.cpp",
"effects/native/graphiceqeffect.cpp",
"effects/native/flangereffect.cpp",
Expand Down
4 changes: 3 additions & 1 deletion src/control/controlbehavior.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,12 @@ double ControlAudioTaperPotBehavior::parameterToValue(double dParam) {
}
} else if (dParam == m_neutralParameter) {
dValue = 1.0;
} else if (dParam <= 1.0) {
} else if (dParam < 1.0) {
// m_maxDB = 1
// 0 dB = m_neutralParame;
dValue = db2ratio((dParam - m_neutralParameter) * m_maxDB / (1 - m_neutralParameter));
} else {
dValue = db2ratio(m_maxDB);
}
//qDebug() << "ControlAudioTaperPotBehavior::parameterToValue" << "dValue =" << dValue << "dParam =" << dParam;
return dValue;
Expand Down
17 changes: 7 additions & 10 deletions src/effects/native/bessel4lvmixeqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,13 @@ void Bessel4LVMixEQEffect::processChannel(const ChannelHandle& handle,
Q_UNUSED(handle);
Q_UNUSED(groupFeatures);

double fLow;
double fMid;
double fHigh;
if (enableState == EffectProcessor::DISABLING) {
// Ramp to dry, when disabling, this will ramp from dry when enabling as well
fLow = 1.0;
fMid = 1.0;
fHigh = 1.0;
pState->processChannelAndPause(pInput, pOutput, numSamples);
} else {
double fLow;
double fMid;
double fHigh;
if (!m_pKillLow->toBool()) {
fLow = m_pPotLow->value();
} else {
Expand All @@ -145,9 +143,8 @@ void Bessel4LVMixEQEffect::processChannel(const ChannelHandle& handle,
} else {
fHigh = 0;
}
pState->processChannel(pInput, pOutput, numSamples, sampleRate,
fLow, fMid, fHigh,
m_pLoFreqCorner->get(), m_pHiFreqCorner->get());
}

pState->processChannel(pInput, pOutput, numSamples, sampleRate,
fLow, fMid, fHigh,
m_pLoFreqCorner->get(), m_pHiFreqCorner->get());
}
18 changes: 8 additions & 10 deletions src/effects/native/bessel8lvmixeqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,14 @@ void Bessel8LVMixEQEffect::processChannel(const ChannelHandle& handle,
Q_UNUSED(handle);
Q_UNUSED(groupFeatures);

double fLow;
double fMid;
double fHigh;

if (enableState == EffectProcessor::DISABLING) {
// Ramp to dry, when disabling, this will ramp from dry when enabling as well
fLow = 1.0;
fMid = 1.0;
fHigh = 1.0;
pState->processChannelAndPause(pInput, pOutput, numSamples);
} else {
double fLow;
double fMid;
double fHigh;
if (!m_pKillLow->toBool()) {
fLow = m_pPotLow->value();
} else {
Expand All @@ -145,9 +144,8 @@ void Bessel8LVMixEQEffect::processChannel(const ChannelHandle& handle,
} else {
fHigh = 0;
}
pState->processChannel(
pInput, pOutput, numSamples, sampleRate, fLow, fMid, fHigh,
m_pLoFreqCorner->get(), m_pHiFreqCorner->get());
}

pState->processChannel(pInput, pOutput, numSamples, sampleRate,
fLow, fMid, fHigh,
m_pLoFreqCorner->get(), m_pHiFreqCorner->get());
}
Loading