Logging updates:#1159
Merged
rryan merged 3 commits intomixxxdj:masterfrom Jan 30, 2017
Merged
Conversation
Member
rryan
commented
Jan 29, 2017
rryan
commented
- Rename --debugLevel to --logLevel and use English names for the levels.
- Add qInfo support when Qt5 is used.
- Bypass --logLevel for controller debug statements when --controllerDebug is enabled.
* Rename --debugLevel to --logLevel and use English names for the levels. * Add qInfo support when Qt5 is used. * Bypass --logLevel for controller debug statements when --controllerDebug is enabled.
Contributor
|
Should --developer also bypass --logLevel like --controllerDebug? |
Member
Author
You mean set log level to 'debug' if --developer is set? SGTM |
Contributor
Yes, that's what I mean. |
Contributor
|
I have tested this and it works well. Thanks! |
Contributor
|
--controllerDebug should turn on printing from JS without having to specify --logLevel debug |
Member
Author
Good point -- done. |
Contributor
|
I tested again and it works. LGTM. 👍 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.