Skip to content

Traktor S3: Fix script startup #11463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ywwg wants to merge 3 commits into from
Closed

Traktor S3: Fix script startup #11463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b8e228
Traktor S3: Fix script startup
ywwg Apr 10, 2023
8f5ae39
Merge remote-tracking branch 'origin/2.4' into 2.4
ywwg Apr 22, 2023
0dbf7b8
Also remove bad incomingData call from S2 mapping
ywwg Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions res/controllers/Traktor-Kontrol-S2-MK3-hid-scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,6 @@ TraktorS2MK3.registerInputPackets = function() {
for (let i = 1; i <= 16; ++i) {
engine.softTakeover("[Sampler" + i + "]", "pregain", true);
}

// Dirty hack to set initial values in the packet parser
const data = [1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0];
TraktorS2MK3.incomingData(data);
};

TraktorS2MK3.registerInputJog = function(message, group, name, offset, bitmask, callback) {
Expand Down
4 changes: 0 additions & 4 deletions res/controllers/Traktor-Kontrol-S3-hid-scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1750,10 +1750,6 @@ TraktorS3.Controller.prototype.registerInputPackets = function() {
engine.connectControl(ch, "end_of_track",
TraktorS3.bind(TraktorS3.Channel.prototype.endOfTrackHandler, chanob));
}

// Dirty hack to set initial values in the packet parser
const data = [1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0];
TraktorS3.incomingData(data);
};

TraktorS3.Controller.prototype.registerInputJog = function(message, group, name, offset, bitmask, callback) {
Expand Down