Post Visual Studio 2015 Upgrade#1139
Merged
rryan merged 6 commits intomixxxdj:masterfrom Jan 21, 2017
uklotzde:post_vs2015_upgrade
Merged
Post Visual Studio 2015 Upgrade#1139rryan merged 6 commits intomixxxdj:masterfrom uklotzde:post_vs2015_upgrade
rryan merged 6 commits intomixxxdj:masterfrom
uklotzde:post_vs2015_upgrade
Conversation
Contributor
|
Thank you, it works for me on gcc 6.2 |
Contributor
Author
|
Still struggling to get everything right to make the build pass on all platforms ;) |
rryan
reviewed
Jan 21, 2017
| static const SINT kSamplingRate; | ||
| static const SINT kBitsPerSample; | ||
| static constexpr SINT kChannelCount = kChannelCountStereo; | ||
| static constexpr SINT kSamplingRate = 16; |
Member
There was a problem hiding this comment.
ITYM
kSamplingRate = 44100;
kBitsPerSample = 16;
:)
rryan
reviewed
Jan 21, 2017
| static constexpr CSAMPLE kPeakMin = CSAMPLE_ZERO; // lower bound (inclusive) | ||
| static constexpr CSAMPLE kPeakClip = CSAMPLE_PEAK; // upper bound (inclusive) represents digital full scale without clipping | ||
|
|
||
| // TODO(uklotzde): Uncomment after switching to Visual Studio 2015 |
daschuer
reviewed
Jan 21, 2017
| static const SINT kBitsPerSample; | ||
| static constexpr SINT kChannelCount = kChannelCountStereo; | ||
| static constexpr SINT kSamplingRate = 44100; | ||
| static constexpr SINT kBitsPerSample = 16; |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual Studio 2015 is now the minimum requirement for compiling Mixxx on Windows.
This PR includes the definition of missing static const/constexpr class constants detected with optimize=off. Visual Studio 2013 didn't like those.
I did NOT remove any version checks in external sources that we just copied!