Replace QSharedPointer with std::shared_ptr#1132
Merged
daschuer merged 1 commit intomixxxdj:masterfrom Jan 18, 2017
uklotzde:std_shared_ptr
Merged
Replace QSharedPointer with std::shared_ptr#1132daschuer merged 1 commit intomixxxdj:masterfrom uklotzde:std_shared_ptr
daschuer merged 1 commit intomixxxdj:masterfrom
uklotzde:std_shared_ptr
Conversation
Member
|
I have found an interesting benchmark using shared pointers: Result: QSharedPointer is faster in Qt 4 but slightly slower in Qt 5 compared to the boost alternative which should match the std:: This means, we should merge it after switching to Qt 5 :-P Thank you for the work! LGTM. |
Contributor
Author
|
Thanks @daschuer! One branch less that I need to update ;) |
Member
|
May have caused this bug: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace some QSharedPointer types with std::shared_ptr from C++11.
Tested during the last months without any issues.