Fix the Latenight skin quick effect toggle controls only affecting the first effect of the chain#11135
Conversation
In the Latenight skin when clicking on the bypass buttons next to the quick effect super knobs.
|
The |
|
Thanks for the fix! That is obviously a leftover and I wonder why it wasn't discovered earlier... Here's the commit that fixes the knob/button visibility conection c0acd2b
well, we may discuss that again. IIRC that's LateNight legacy behaviour and I appreciate it since it allows a clean UI in case you never use QuickEffects (like I do), it's simply one less thing to care about. |
|
Oh awesome! I've already redone my effect chains so that the first effect is always used (I liked keeping the middle one as a filter so I can easily add something before or after it when saving a new preset), but it's nice to not have to do that ha. |
|
Great : )
Feel free to pick that for this PR. |
|
Done. |
|
Thanks. |
I noticed that the quick effect chain bypass wasn't working correctly for effect chain presets with multiple effects (and setting the correct value from my controller didn't result in any visible feedback in the GUI). The other skins seem to already do the right thing here, so this was probably just an oversight.