MacOs + Windows link against the Release version of Libraries #10899
Closed
daschuer wants to merge 2 commits intomixxxdj:2.3from
Closed
MacOs + Windows link against the Release version of Libraries #10899daschuer wants to merge 2 commits intomixxxdj:2.3from
daschuer wants to merge 2 commits intomixxxdj:2.3from
Conversation
daschuer
force-pushed
the
RelWithDebInfoToRelease
branch
from
130766b to
ee2f60a
Compare
daschuer
force-pushed
the
RelWithDebInfoToRelease
branch
from
ee2f60a to
63ae85f
Compare
daschuer
force-pushed
the
RelWithDebInfoToRelease
branch
from
ae54b62 to
7ace51c
Compare
Member
|
This could explain the reduced performance, I noticed on Windows after an buildenv update: #4717 (comment) |
Member
Author
|
This PR was based in a wrong assumption I get from a wrong debug statement. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we build no RelWithDebInfo configuration with vcpkg cmake picks the fist configuration found which can be by luck Release or Debug.
Some Qt Libraries are linked with the debug version, which should be one major cause of the MacOs regression that has been tracked down to the commit where the VCPKG environment has been introduced for macOs builds.
The windows build should be affected in the same way.