Merged
Conversation
rryan
reviewed
Dec 21, 2016
| void WWidgetGroup::setHighlight(int highlight) { | ||
| m_highlight = highlight; | ||
| update(); | ||
| style()->polish(this); |
Member
There was a problem hiding this comment.
Should probably do it like WPushButton::restyleAndRepaint:
https://github.com/mixxxdj/mixxx/blob/master/src/widget/wpushbutton.cpp#L264
Based on http://stackoverflow.com/a/3822243 we believe that's the best way to trigger re-computation of the styles.
Contributor
Author
There was a problem hiding this comment.
QWidget documentation suggests calling update() is better than directly calling repaint().
Member
There was a problem hiding this comment.
Yea, that WPushButton one should probably be an update, not a repaint (we typically only use repaint for things that update on the waveform timer). I meant add an unpolish here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make #1068 work after skin has been initialized