Adding CUP button and CUP mode.#1010
Conversation
modified: src/controllers/controlpickermenu.cpp
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
For now I have added only some style nits. The rest looks good to me.
I will test this soon.
| cueSet(v); | ||
| // Just in case. | ||
| m_bPreviewing = false; | ||
| } |
There was a problem hiding this comment.
In the Block above, you have still tabs.
| } else { | ||
| } else if (cueMode == CUE_MODE_CUP) { | ||
| cuePlay(v); | ||
| } else { |
|
I removed the tabs. Let me know if you find any issues testing! |
|
Works great, Thank you very much! LGTM, For testing, I have used the CUP song: |
|
Thanks for the feature. Stop the track and right-click on the PLAY button to place a cue point. Hit the CUE button. Playback starts on release. Now enable Quantization, and again, stop the track and right-click on the PLAY button to place a cue point. Hit the CUE button and release. Nothing happens. |
|
How do I go about enabling Quantization? I want to try and reproduce it and see if I can fix it. |
Click the |
This reverts commit 5590b0a.
This reverts commit 1d99f83.
5 participants
https://bugs.launchpad.net/mixxx/+bug/1535468
The CUP mode has been added. It works the following way:
It is available as a Cue mode, or as a button that can be learned.
This is a fixed version of PR #1001