do not change speed of playing decks if "Reset Speed/Tempo" preference is checked#1002
Merged
daschuer merged 3 commits intomixxxdj:masterfrom Sep 6, 2016
Merged
Conversation
Be-ing
force-pushed
the
unexpected_tempo_change_fix
branch
from
04fdb66 to
7da3e1f
Compare
Be-ing
force-pushed
the
unexpected_tempo_change_fix
branch
from
7da3e1f to
9141ee1
Compare
requires a little refactoring of MockedEngineBackendTest
Contributor
Author
|
Okay, test written and ready for review. I had to do some refactoring of MockedEngineBackendTest to do so. All the EngineSyncTest tests are still working. I can't confirm the refactoring didn't break any other tests because other tests are crashing on my system (on the master branch): EDIT: Well, it looks like Travis is still passing all tests. |
|
|
||
| bool EngineSync::otherSyncedPlaying(const QString& group) { | ||
| int othersInSync = 0; | ||
| foreach (Syncable* theSyncable, m_syncables) { |
Member
There was a problem hiding this comment.
use the new C++11 range based loop
for (Syncable* theSyncable: m_syncables)
plus minor code clean up
Member
|
Travis fails, not your fault: |
Member
|
LGTM Thank you! |
Contributor
Author
|
Good catch. Yes, I'll take a closer look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.launchpad.net/mixxx/+bug/1603591
I'll write a test to prevent a regression, so don't merge this yet.