docs: Add Stem VU Meter controls to appendix#841
Conversation
|
Please target this to main branch, same as the PR with the code |
Ok. Does this look fine to you? (The number of file changes got me worried 😓 ) |
|
You only changed the target of the PR on the GitHub website. You need also to rebase your git branch. |
xARSENICx
force-pushed
the
stem-vu-meter-docs
branch
from
1c68387 to
f18fb0a
Compare
acolombier
left a comment
acolombier
left a comment
There was a problem hiding this comment.
Previously, the decision was made to document [ChannelN_StemM] COs alongside other channel COs ([ChannelX], [SamplerX] or [PreviewDeckX]). Either those new CO should be brought in the same way, alongside the other existing vu_meter_... sections, or we should bring those existing one the newly introduced section.
xARSENICx
force-pushed
the
stem-vu-meter-docs
branch
from
f18fb0a to
fe960ec
Compare
|
Some conflict have developed, could you please resolve them @xARSENICx ? |
xARSENICx
force-pushed
the
stem-vu-meter-docs
branch
from
ffe85ba to
c8aaa8e
Compare
|
Done |
|
@ronso0 are you happy if we merge this PR? |
|
Totally happy : ) |
| .. versionchanged:: 2.6.0 | ||
| Added :mixxx:coref:`[ChannelN_StemM],vu_meter`. |
There was a problem hiding this comment.
oh, we don't new controls here IMO (same for left/right)
There was a problem hiding this comment.
I didn't get you exactly. Are you suggesting that explanation at the top suffices?
There was a problem hiding this comment.
never mind, got confused with the position in the file 🙈
All good, will merge now
|
Upsi, overlooked the changes in the deprecated section. |
4 participants
Goes with PR.
This is my first time writing manual doc for a feature, so I apologize for any lack of foresight