controls: refine loop_anchor description, clarify range#719
Conversation
|
Hi, I'm a bit confused because I don't see |
ronso0
force-pushed
the
loop-reverse-controls
branch
from
806465d to
51a499e
Compare
|
🤔 I remember I typed that but it got lost somehow. Fixed.
I moved |
acolombier
left a comment
acolombier
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this missing CO
|
Letting @Holzhaus a chance to check this PR again before pressing merge... |
|
Ready, steady, go? |
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
This is not fully self-explanatory for someone that doesn't know this feature at all.
| Like :mixxx:coref:`[ChannelN],beatloop_X_activate` except that the loop is created | ||
| backwards from the current play position. |
There was a problem hiding this comment.
how does this interact with loop_anchor? I assume it just ignores it, or does it get inverted?
There was a problem hiding this comment.
This is an explicit control.
Anchor is only relevant for the _x_toggle/activate controls.
ronso0
force-pushed
the
loop-reverse-controls
branch
from
51a499e to
3b786a3
Compare
|
Hahaa #773 I'll check if I missed something but I think this can be closed 😆 |
ronso0
changed the title
loop_anchor and reverse beatloop controlsloop_anchor description, clarify range
|
Yeah, what a waste of time.. though the text is a bit better now IMO |
ronso0
force-pushed
the
loop-reverse-controls
branch
from
3b786a3 to
3570810
Compare
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
Thank you. Sorry for the unnecessary comments on the other sections.
4 participants
loop_anchorbeatloop_rN_togglebeatloop_rN_activatebeatlooproll_rN_activateadded in mixxxdj/mixxx#12745
Closes #715
Preview: here and below