S4MK3: update setting change instruction#634
Merged
Merged
Conversation
acolombier
force-pushed
the
feat/s4-mk3-custom-settings
branch
3 times, most recently
from
420d3e0 to
fc08e5e
Compare
acolombier
force-pushed
the
feat/s4-mk3-custom-settings
branch
from
fc08e5e to
33545f0
Compare
acolombier
force-pushed
the
feat/s4-mk3-custom-settings
branch
from
33545f0 to
b279c70
Compare
ywwg
reviewed
Mar 31, 2024
ywwg
approved these changes
Mar 31, 2024
Member
|
@daschuer should this be targeted at main, or at manual 2.5? I am unclear how the manual PRs work |
Member
|
@ronso0 do you know the answer? |
acolombier
force-pushed
the
feat/s4-mk3-custom-settings
branch
from
4c7d535 to
211807a
Compare
Merged
Member
main is correct here, we don't have a 2.5 branch. |
acolombier
force-pushed
the
feat/s4-mk3-custom-settings
branch
from
f65c715 to
211807a
Compare
ronso0
reviewed
Apr 8, 2024
ronso0
reviewed
Apr 8, 2024
Member
ronso0
left a comment
ronso0
left a comment
There was a problem hiding this comment.
LGTM, only the points I have commented on could be improved a little
ronso0
approved these changes
Apr 14, 2024
Member
ronso0
left a comment
ronso0
left a comment
There was a problem hiding this comment.
LGTM, thank you for this improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes together with this one for S4MK3 settings