Skip to content

Sphinx link check fix #481

Merged
Swiftb0y merged 7 commits intomixxxdj:2.3from
daschuer:user-content
May 16, 2022
Merged

Sphinx link check fix #481
Swiftb0y merged 7 commits intomixxxdj:2.3from
daschuer:user-content

Conversation

@daschuer
Copy link
Copy Markdown
Member

@daschuer daschuer commented May 4, 2022

This fixes some links and put the rest to linkcheck_ignore. This way we get rid of the permanent failing CI.
The pre-commit failure is fixed here: #482

@Swiftb0y
Copy link
Copy Markdown
Member

Swiftb0y commented May 5, 2022

Can you rebase now that #482 has been merged?

@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented May 5, 2022

Done

@Swiftb0y
Copy link
Copy Markdown
Member

Swiftb0y commented May 5, 2022

Thank you. We should documents somewhere that authors need to fixup anchors on github wikis.

@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented May 5, 2022

Thank you. We should documents somewhere that authors need to fixup anchors on github wikis.

Or even better, we could make a little script that auto-replaces the anchors and add that as a pre-commit hook.

For reference, I documented the Shell commands i used for bulk replacing the anchors in the commit message back then (see 71916cd), but I suppose Python script would be preferable so that it also works for Windows users.

@Swiftb0y
Copy link
Copy Markdown
Member

Swiftb0y commented May 5, 2022

Or even better, we could make a little script that auto-replaces the anchors and add that as a pre-commit hook.

I agree, but I didn't want the scope of this PR to grow ten-fold.

@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented May 5, 2022

Ah, I took your comment as a general recommendation, not a request to add documentation as part of this PR.

@Swiftb0y
Copy link
Copy Markdown
Member

I went ahead and implemented the auto-fixup myself. I've never implemented a pre-commit hook, also my python is a bit dusty. I'd appreciate a thorough review. daschuer#4

@daschuer
Copy link
Copy Markdown
Member Author

The script is merged. Thank you @Swiftb0y.
Can we merge this now?

Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Whats our policy on merging PRs from multiple authors? Parts of this PR are technically mine so am I still allowed to merge? Does somebody else want to hit the button?

@daschuer
Copy link
Copy Markdown
Member Author

You part has been reviewed by me and Jan, so I think the second pair of eyes rules is fulfilled if you just press merge.

@Swiftb0y Swiftb0y merged commit a842bf1 into mixxxdj:2.3 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants