Sphinx link check fix #481
Conversation
|
Can you rebase now that #482 has been merged? |
|
Done |
|
Thank you. We should documents somewhere that authors need to fixup anchors on github wikis. |
Or even better, we could make a little script that auto-replaces the anchors and add that as a pre-commit hook. For reference, I documented the Shell commands i used for bulk replacing the anchors in the commit message back then (see 71916cd), but I suppose Python script would be preferable so that it also works for Windows users. |
I agree, but I didn't want the scope of this PR to grow ten-fold. |
|
Ah, I took your comment as a general recommendation, not a request to add documentation as part of this PR. |
|
I went ahead and implemented the auto-fixup myself. I've never implemented a pre-commit hook, also my python is a bit dusty. I'd appreciate a thorough review. daschuer#4 |
feat(pre-commit): automatically fix html anchors in github wikis
|
The script is merged. Thank you @Swiftb0y. |
Swiftb0y
left a comment
There was a problem hiding this comment.
LGTM. Whats our policy on merging PRs from multiple authors? Parts of this PR are technically mine so am I still allowed to merge? Does somebody else want to hit the button?
|
You part has been reviewed by me and Jan, so I think the second pair of eyes rules is fulfilled if you just press merge. |
This fixes some links and put the rest to linkcheck_ignore. This way we get rid of the permanent failing CI.
The pre-commit failure is fixed here: #482