Conversation
Ran `make gettext`, which updated a bunch of other files as well
|
(broken links are not in the new entry) |
Please put these changes into a separate PR IMHO. |
|
My mistake, shouldn't have merged the controller mapping without the manual entry |
|
ok now it just includes the new file |
| ~~~~~~~~~~ | ||
|
|
||
| The MiniMixxx is a USB class compliant MIDI device. To work correctly with this | ||
| mapping, you should load blah blah blah custom layout. |
There was a problem hiding this comment.
hahahahhaahhaa sorry. The controller requires a specific config to be loaded on it, I have to attach that
|
(I am also working with yaeltex to make this config loaded on controllers by default) |
|
Feel free to ping me when this is ready to review |
|
link checker fixed in head. @Swiftb0y ready for review |
|
ping |
|
oh! I didn't see the comments. I will address |
|
ping |
|
Hello @ywwg, when will you address the review remarks? We need this manual for 2.4 - without this, we would have to reverse the merge of the mapping PR. |
|
sorry for not seeing the pings, github notifications don't work for me (I get literally hundreds per day due to my company's configuration). working on this now |
|
Thank you! |
|
notes addressed I believe! thank you for your multi-year patience gahhh |
| :alt: Yaeltex Minimixxx (product image) | ||
| :figclass: pretty-figures | ||
|
|
||
| Vestax VCI-400 (top view with annotations) |
There was a problem hiding this comment.
| Vestax VCI-400 (top view with annotations) | |
| Yaeltex Minimixxx (top view with annotations) |
| Mapping description | ||
| ------------------- | ||
|
|
||
| .. figure:: ../../_static/controllers/yaeltex_minimixxx.jpg |
There was a problem hiding this comment.
Do we have a permission to use this photo, or is it your own work?
There was a problem hiding this comment.
I was working with the manufacturer to design the controller and they are ok with this.
Swiftb0y
dismissed
their stale review
Thanks for addressing my previous comments. Unfortunately I'm unable to do a proper review right now.
|
LGTM! Thank you! |
4 participants
Ran
make gettext, which updated a bunch of other files as well