feat(error): Add validation error classes for YouTube ID and URL #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new error classes for more specific validation error handling: - `IDValidationError`: Represents errors for invalid YouTube video IDs during validation. - `URLValidationError`: Represents errors for invalid YouTube video URLs during validation. - `UnknownYouTubeDomainError`: Represents errors due to invalid or unknown YouTube domains. - Updated the `error` module to export the new error classes. These additions provide better error handling and clarity for validation-related operations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 80.49% 80.49%
=======================================
Files 11 11
Lines 605 605
=======================================
Hits 487 487
Misses 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces three new error classes to improve the granularity and specificity of validation error handling for YouTube video IDs and URLs. These classes are part of the
errormodule and are designed to provide clearer error messages and better debugging capabilities when validation fails.Changes Made
Introduced New Error Classes
IDValidationError: Represents errors raised when a YouTube video ID fails validation.URLValidationError: Represents errors raised when a YouTube video URL fails validation.UnknownYouTubeDomainError: Represents errors raised when an invalid or unknown YouTube domain is detected.Updated the
errorModule ExportsDocumentation Addition
@classdescannotations for each new class, specifying its purpose and usage.Impact
Summary
This PR enhances validation-related error handling for YouTube video IDs, URLs, and domains by introducing specific error classes. These improvements make error handling more precise and debugging easier, benefiting developers and users alike.