Add internal MP3 converter feature #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preventing long file names, and video musics in YouTube almost has the author name within their title videos.
Now the output file names will not have any illegal characters
anymore and prevent errors during I/O processes. The illegal
character will be replaced by an underscore character ('_').
* Declared the abstract function of the MP3 converter * Imported several required modules
* Now the audio file will be converted to MP3 immediately after being downloaded. * Refactored the output file path creation * Added `await` operator on call of function `ytdl.downloadFromInfo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Refactor Main Entry File
awaitoperator to theytdl.downloadFromInfofunction call.Initialize
acodecs-cvtFileacodecs-cvt.convertToMp3that converts any audio codecs to MP3 codec.optionsMp3.Maintanances
Dependencies
fluent-ffmpegdependency (production).All commits
acodecs-cvtmoduleindex.jsfluent-ffmpegdependency❗ Disadvantages
Concurrent execution is a significant disadvantage when doing audio conversion with numerous processes. Concurrent process execution may result in the collision of progression percentages, thereby causing confusion and mistakes in tracking the individual progress of each process. This lack of synchronization in progress reporting might lead to a less intuitive user experience and make determining the real-time state of each conversion process difficult. To minimize this disadvantage, a synchronized approach to progress reporting might be considered.
Summary
This pull request introduces several enhancements and a new feature to convert the downloaded audio to MP3 codec. It includes refactoring, the addition of functionalities, and the introduction of a new module for audio codecs conversion (
acodecs-cvt).