fix: Correct arraycopy source and destination in dropRow method
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the source and destination parameters in `System.arraycopy` to correctly handle the dropping of a row from the matrix. - The source was incorrectly set to `newEntries[destRow++]`, which is now updated to `entries[i]`, and the destination is updated to `newEntries[destRow++]`.
mitsuki31
added
bugfix
mitsuki31
deleted the
fix/address-incorrect-call-arraycopy-in-drop-row
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses an issue in the
Matrixclass where theSystem.arraycopymethod was used incorrectly in thedropRowmethod. Specifically, the source and destination parameters inSystem.arraycopywere swapped, which led to improper handling of row removal from the matrix.Changes Made
System.arraycopy:newEntries[destRow++]toentries[i].entries[i]tonewEntries[destRow++].These changes ensure that the correct row data is copied from the original matrix to the new matrix after a row has been dropped.
Reason for the Change
The initial implementation of
System.arraycopymistakenly swapped the source and destination arrays. As a result, thedropRowmethod did not correctly transfer data from the original matrix to the new matrix, potentially leading to incorrect matrix content.Impact
This fix corrects the behavior of row removal in the
Matrixclass, ensuring that the matrix operations produce accurate results. Users of theMatrixclass should experience improved reliability when performing row deletions.