Allow debug expressions in redaction macros
#455
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
force-pushed
the
redaction-debug
branch
from
7f160b5 to
51e1be4
Compare
It's can be a bit confusing when some macros have features which others don't have. So this adds debug expressions to the redaction macros. (Though they do get quite long; possibly we want to recommend something like `description` in place of `debug` throughout?)
max-sixty
force-pushed
the
redaction-debug
branch
from
51e1be4 to
2959d79
Compare
max-sixty
added a commit
to max-sixty/insta-website
that referenced
this pull request
Mar 5, 2024
Consistent with mitsuhiko/insta#455 Also slightly adjusts the ordering to make it read consistently from the intro
Collaborator
Author
|
This is rebased and ready for merging / review |
mitsuhiko
pushed a commit
to mitsuhiko/insta-website
that referenced
this pull request
Apr 18, 2024
Consistent with mitsuhiko/insta#455 Also slightly adjusts the ordering to make it read consistently from the intro
Collaborator
Author
|
I forgot about this and did it in #756! so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be a bit confusing when some macros have features which others don't. So this adds debug expressions to the redaction macros.
(Though the calls do get quite long; possibly we want to recommend something like
descriptionin place ofdebugthroughout?)