Skip to content

Commit

Permalink
Adapt Dr.Jit to Dr.Jit-Core code generation
Browse files Browse the repository at this point in the history
This PR makes Dr.Jit compatible with the following Dr.Jit-Core PRs:

- mitsuba-renderer/drjit-core#40
- mitsuba-renderer/drjit-core#41
  • Loading branch information
wjakob committed Nov 30, 2022
1 parent d5f4e65 commit 1af8233
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion ext/drjit-core
4 changes: 0 additions & 4 deletions include/drjit/loop.h
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,6 @@ struct Loop<Mask, enable_if_jit_array_t<Mask>> {
if (!m_record)
return;

// Capture JIT state and begin recording session
m_jit_state.new_scope();

// Rewrite loop state variables (1)
m_loop_init = jit_var_loop_init(m_indices.size(), m_indices.data());

Expand Down Expand Up @@ -299,7 +296,6 @@ struct Loop<Mask, enable_if_jit_array_t<Mask>> {
m_indices_prev.clear();

m_jit_state.end_recording();
m_jit_state.clear_scope();
m_jit_state.clear_mask_if_set();
jit_var_mark_side_effect(rv);

Expand Down
3 changes: 2 additions & 1 deletion include/drjit/vcall_jit_record.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ Result vcall_jit_record_impl(const char *name, uint32_t n_inst,

detail::JitState<Backend> jit_state;
jit_state.begin_recording();
jit_state.new_scope();

state[0] = jit_record_checkpoint(Backend);

Expand Down Expand Up @@ -156,6 +155,7 @@ Result vcall_jit_record_impl(const char *name, uint32_t n_inst,

jit_state.end_recording();
jit_var_mark_side_effect(se);
jit_new_scope(Backend);

if constexpr (!std::is_same_v<Result, std::nullptr_t>) {
Result result;
Expand Down Expand Up @@ -236,6 +236,7 @@ Result vcall_jit_record(const char *name, const Func &func, Self &self,
std::make_index_sequence<sizeof...(Args)>(), args...);
} else {
isolate_grad<DiffType> guard;
jit_new_scope(Backend);

return vcall_jit_record_impl<Result, Base>(
name, n_inst, func, self, mask,
Expand Down

0 comments on commit 1af8233

Please sign in to comment.